fix: Support Union and Optional in DataType.infer_from_type#6304
Open
fix: Support Union and Optional in DataType.infer_from_type#6304
DataType.infer_from_type#6304Conversation
srilman
commented
Feb 27, 2026
| - "metadata" or "wat": Metadata about crawled pages | ||
| + "raw" or "warc": Raw WARC files containing full HTTP responses | ||
| + "text" or "wet": Extracted plain text content | ||
| + "metadata" or "wat": Metadata about crawled pages |
Contributor
Author
There was a problem hiding this comment.
I noticed that in VSCode rendering, it is happier with + signs then - or *. All three are valid in Markdown, and others like IPython don't care. So I vote for using these.
srilman
commented
Feb 27, 2026
| (list[list], dt.list(dt.list(dt.python()))), | ||
| (list[list[str]], dt.list(dt.list(dt.string()))), | ||
| ( | ||
| pytest.param(type(None), dt.null(), id="null"), |
Contributor
Author
There was a problem hiding this comment.
Added labels so its easier to tell which one fails
Contributor
Greptile SummaryThis PR adds support for Union and Optional types in Implementation approach:
Test coverage: Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 7b35a0f |
DataType.infer_from_type.DataType.infer_from_type.=
DataType.infer_from_type.=DataType.infer_from_type\
DataType.infer_from_type\DataType.infer_from_type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
Noticed it when I was writing some other test, and got really annoying so I just dealt with it.
Note that the workarounds seem kind of bad, so I might take a better look at it at another point. Just a temp solution.