Add linting and fix linting errors

.evertras/pre-commit.sh

@@ -9,6 +9,8 @@ files=$(git diff --cached --name-only --diff-filter=ACMR | sed 's| |\\ |g')
 
 [ -z "$files" ] && exit 0
 
+make lint
+
 echo "$files" | xargs npx prettier --ignore-unknown --write
 echo "$files" | xargs nixfmt
 go fmt ./...

.github/workflows/lint.yaml

@@ -0,0 +1,20 @@
+name: golangci-lint
+on:
+  push:
+    tags:
+      - v*
+    branches:
+      - main
+  pull_request:
+permissions:
+  contents: read
+jobs:
+  golangci:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v3
+        with:
+          version: v1.51.1

Makefile

@@ -28,6 +28,10 @@ coverage.out: $(GO_FILES)
 
 ################################################################################
 # Lint / Format
+.PHONY: lint
+lint: git-hooks
+	golangci-lint run ./...
+
 .PHONY: fmt
 fmt: node_modules git-hooks
 	go fmt ./...

cmd/yakdash/cmds/root.go

@@ -35,7 +35,10 @@ func init() {
 
 	flags.StringVarP(&cfgFile, "config", "c", "", "The config file to use")
 
-	viper.BindPFlags(flags)
+	err := viper.BindPFlags(flags)
+	if err != nil {
+		log.Fatal("Failed to bind flags:", err)
+	}
 }
 
 func initConfig() {

flake.nix

@@ -14,6 +14,7 @@
             go
 
             # For dev tools
+            golangci-lint
             nixfmt
             nodejs_21
           ];

pkg/yakdash/build.go

@@ -9,7 +9,7 @@ import (
 )
 
 func New(l layout.Root) model {
-	var p []panes.Pane
+	var allPanes []panes.Pane
 
 	var makePane func(node layout.Node) panes.Pane
 	makePane = func(node layout.Node) panes.Pane {
@@ -37,11 +37,11 @@ func New(l layout.Root) model {
 	}
 
 	for _, node := range l.Screens {
-		p = append(p, makePane(node))
+		allPanes = append(allPanes, makePane(node))
 	}
 
 	return model{
 		layout:   l,
-		rootPane: makePane(l.Screens[0]),
+		rootPane: allPanes[0],
 	}
 }