Repository navigation
Address sea-level review feedback in land-mask generation - #86
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Address sea-level review feedback in land-mask generation
Jun 18, 2026
dramanica
approved these changes
Jun 19, 2026
dramanica
marked this pull request as ready for review
June 19, 2026 09:33
dramanica
added a commit
that referenced
this pull request
Jun 19, 2026
* sea level functions * Add Clark 2025 sea level * minor fixes * Address sea-level review feedback in land-mask generation (#86) * Initial plan * fix review thread feedback for sea level handling * refine review-fix tests * polish sea level tests * some comments --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Andrea Manica <am315@cam.ac.uk> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the sea-level handling introduced in the PR to match the linked review thread. It restores backward-compatible
NULLbehavior inmake_land_mask(), documents supportedsea_levelinputs more clearly, and hardensget_sea_level()around invalid time ranges and malformed baseline data.make_land_mask()compatibility and docssea_level = NULLasSpratt2016to preserve prior caller behavior.sea_levelmay be:"Spratt2016""Clark2025"time_bpget_sea_level()validationtime_bp > 0) explicitly instead of relying on interpolation failure.NAvalues in the range test.Baseline rescaling safety
time_bp == 0row before rescaling to present-day sea level.Focused regression coverage
sea_level = NULLbehaving asSpratt2016.time_bp.Example: