Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjusting cloud api send audio and video #1287

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

pedroepif
Copy link

@pedroepif pedroepif commented Mar 5, 2025

This commit fix sending video and audio in cloud api service:

  • Send video should not send fileName.
  • Send audio was sending as media with incorrect params.

Summary by Sourcery

Fixes issues with sending audio and video in the Cloud API service. Specifically, it ensures that video messages do not include the filename parameter and corrects the parameters used when sending audio messages.

Bug Fixes:

  • Fixes an issue where video messages were incorrectly sending the filename parameter.
  • Fixes an issue where audio messages were being sent with incorrect parameters.

Copy link

sourcery-ai bot commented Mar 5, 2025

Reviewer's Guide by Sourcery

This pull request addresses issues with sending audio and video messages via the cloud API. It prevents sending the filename for video messages, corrects the media parameter for audio messages, and simplifies the audio processing logic.

Sequence diagram for sending video message

sequenceDiagram
  participant Client
  participant BusinessStartupService
  participant WhatsAppAPI

  Client->>BusinessStartupService: Send video message (media, mimetype, fileName)
  BusinessStartupService->>BusinessStartupService: Check if media is video
  BusinessStartupService->>WhatsAppAPI: Send media ID, preview_url, caption (no filename if video)
  WhatsAppAPI-->>BusinessStartupService: Success/Failure
  BusinessStartupService-->>Client: Success/Failure
Loading

File-Level Changes

Change Details Files
Modified the conditions for sending the filename in video messages.
  • Added a condition to prevent sending the filename for video messages.
src/api/integrations/channel/meta/whatsapp.business.service.ts
Corrected the media parameter when sending audio messages.
  • Replaced mediaMessage.media with mediaMessage.audio when creating the file stream for audio messages.
  • Updated the prepareMedia object to use the audio property instead of media for audio messages.
src/api/integrations/channel/meta/whatsapp.business.service.ts
Simplified the audio processing logic.
  • Removed the conditional logic for handling different audio sources (buffer, URL, undefined file).
  • The audio is now directly converted to base64 if a file is provided.
src/api/integrations/channel/meta/whatsapp.business.service.ts

Possibly linked issues

  • #0: The PR fixes the issue described in the issue. The PR changes how videos and audios are sent in the cloud API, addressing the error message mentioned in the issue.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pedroepif - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why filename should not be sent for videos.
  • The // DO NOTHING comment can be removed.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@pedroepif
Copy link
Author

@DavidsonGomes DavidsonGomes changed the base branch from main to develop March 6, 2025 10:50
@DavidsonGomes
Copy link
Collaborator

Please fix the lint, use npm run lint

@pedroepif
Copy link
Author

Please fix the lint, use npm run lint

Done

@DavidsonGomes DavidsonGomes merged commit ea9c3fb into EvolutionAPI:develop Mar 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants