Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solução para erro ao adicionar um label #1311

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

RodriguesCosta
Copy link

@RodriguesCosta RodriguesCosta commented Mar 14, 2025

Estou criando essa pull request depois de ver que a pull request #1277 estava vindo da branch errada.

Criei a issue #1276

Ao analisar o código percebi que o problema e que no schema prisma do postgresql não temos um index único usando instanceId, remoteJid porem no schema do mysql ele existe, com isso adicionei esse index.

@@unique([instanceId, remoteJid])

Também aproveitei para adicionar a lista de labels no chat ao chamar o endpoint {{baseUrl}}/chat/findChats/{{instance}}

Summary by Sourcery

Fixes an error when adding a label by adding a unique index to the Chat table in the PostgreSQL schema. Also includes the list of labels in the chat when calling the endpoint /chat/findChats/{instance}.

Bug Fixes:

  • Fixes an error when adding a label due to a missing unique index in the PostgreSQL schema.
  • Includes the list of labels in the chat when calling the endpoint /chat/findChats/{instance}.

Copy link

sourcery-ai bot commented Mar 14, 2025

Reviewer's Guide by Sourcery

This pull request addresses an issue where a unique index was missing in the PostgreSQL schema for the Chat table, which existed in the MySQL schema. A migration was added to create this index. Additionally, the pull request includes the labels field in the response of the findChats endpoint.

Sequence diagram for fetching chats with labels

Loading
sequenceDiagram
    participant Client
    participant Server
    participant Database

    Client->>Server: GET /chat/findChats/{instance}
    Server->>Database: Query Chat table with labels
    Database-->>Server: Chat data with labels
    Server-->>Client: Response with chat data including labels

File-Level Changes

Change Details Files
Added a unique index to the Chat table in the PostgreSQL schema.
  • Added a migration to create a unique index on the instanceId and remoteJid columns of the Chat table.
  • The index prevents duplicate instanceId and remoteJid combinations in the Chat table.
prisma/postgresql-migrations/20250314220553_add_unique_chat/migration.sql
Included labels in the chat information when calling the findChats endpoint.
  • Modified the query to include the labels field from the Chat table.
  • Added the labels field to the returned chat data.
src/api/services/channel.service.ts

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RodriguesCosta - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It's great you've included the related issue and PR in the description - this helps provide context.
  • Consider if the label list should be added when calling the endpoint {{baseUrl}}/chat/findChat/{{instance}} as well.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant