-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solução para erro ao adicionar um label #1311
base: develop
Are you sure you want to change the base?
Solução para erro ao adicionar um label #1311
Conversation
Reviewer's Guide by SourceryThis pull request addresses an issue where a unique index was missing in the PostgreSQL schema for the Sequence diagram for fetching chats with labelssequenceDiagram
participant Client
participant Server
participant Database
Client->>Server: GET /chat/findChats/{instance}
Server->>Database: Query Chat table with labels
Database-->>Server: Chat data with labels
Server-->>Client: Response with chat data including labels
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @RodriguesCosta - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's great you've included the related issue and PR in the description - this helps provide context.
- Consider if the label list should be added when calling the endpoint
{{baseUrl}}/chat/findChat/{{instance}}
as well.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Estou criando essa pull request depois de ver que a pull request #1277 estava vindo da branch errada.
Criei a issue #1276
Ao analisar o código percebi que o problema e que no schema prisma do postgresql não temos um index único usando instanceId, remoteJid porem no schema do mysql ele existe, com isso adicionei esse index.
@@unique([instanceId, remoteJid])
Também aproveitei para adicionar a lista de labels no chat ao chamar o endpoint {{baseUrl}}/chat/findChats/{{instance}}
Summary by Sourcery
Fixes an error when adding a label by adding a unique index to the Chat table in the PostgreSQL schema. Also includes the list of labels in the chat when calling the endpoint /chat/findChats/{instance}.
Bug Fixes: