Skip to content

Defininando TTL no userDivicesCache igual usado no Baileys #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

theeusmartins
Copy link

@theeusmartins theeusmartins commented Mar 24, 2025

No Canal de Comunição da Evolution com a Baileys, está definido como readonly e sem TTL o userDevicesCache, defini o TTL igual na Baileys.

Pois quando o Usuário reinstala o WhatsApp ( por diversos motivos ) ele refaz a criptografia do número e por esse cache não ter o TTL, para esses usuários fica "Aguardando mensagem. Essa ação pode levar alguns instantes"

Imagem do código no Baileys
image

Summary by Sourcery

Enhancements:

  • Configures a Time-To-Live (TTL) for the userDevicesCache.

Copy link

sourcery-ai bot commented Mar 24, 2025

Reviewer's Guide by Sourcery

This pull request introduces a TTL for the userDevicesCache in the Baileys integration. This change addresses an issue where users who reinstall WhatsApp and re-encrypt their number would get stuck in an 'Awaiting message' state due to the cache not expiring. The TTL is set to 300000 milliseconds (5 minutes), and cloning is disabled for the cache.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Configured a Time-To-Live (TTL) for the userDevicesCache.
  • Added a stdTTL option to the userDevicesCache configuration, setting it to 300000 (milliseconds).
  • Added a useClones option to the userDevicesCache configuration, setting it to false.
src/api/integrations/channel/whatsapp/whatsapp.baileys.service.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @theeusmartins - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider extracting the cache configuration into a dedicated configuration file or section for better maintainability.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +229 to +231
private readonly userDevicesCache: CacheStore = new NodeCache({
stdTTL: 300000,
useClones: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (bug_risk): Double-check stdTTL units for NodeCache.

NodeCache’s stdTTL option typically expects a time value in seconds. With the current value of 300000, ensure that the intended cache duration and unit are correct, so that the cache does not inadvertently persist data longer than expected.

@nestordavalos
Copy link
Contributor

Olá, como vai? Espero que você esteja bem.
Pergunta: Por que você diz isso e por que define 5.000 min?

@theeusmartins
Copy link
Author

Olá, como vai? Espero que você esteja bem. Pergunta: Por que você diz isso e por que define 5.000 min?

Oá amigo, esse 5 minutos está definido na baileys, essa parte do código é referente a conexão via baileys

link do comando: https://github.com/WhiskeySockets/Baileys/blob/f19ffa7cca270d3b17bb04a019f68678ce1faca5/src/Socket/messages-send.ts#L37

@nestordavalos
Copy link
Contributor

Olá, como vai? Espero que você esteja bem. Pergunta: Por que você diz isso e por que define 5.000 min?

Oá amigo, esse 5 minutos está definido na baileys, essa parte do código é referente a conexão via baileys

link do comando: https://github.com/WhiskeySockets/Baileys/blob/f19ffa7cca270d3b17bb04a019f68678ce1faca5/src/Socket/messages-send.ts#L37

Eu sei, mas você colocou
stdTTL: 300000 // é igual a 5.000 minutos ≈ 3 dias e 11 horas
em todo caso tem
stdTTL: 300 // 5 minutos (300 segundos)

Estou testando, mas continua a mesma coisa, para mim é outra coisa.

@DavidsonGomes DavidsonGomes changed the base branch from main to develop March 26, 2025 12:58
@DavidsonGomes
Copy link
Collaborator

Ajuste o lint por favor, estava para a branch main, o correto é para a develop, rode o compando npm run lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants