SOF-6944: specify array items for apps under psp/file_data_item #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json-to-simpl-schema has issues handling empty arrays
pranabdas
force-pushed
the
fix/SOF-6944
branch
from
e358cd5 to
036de5f
Compare
| @@ -54,7 +54,10 @@ | |||
| }, | |||
| "apps": { | |||
| "type": "array", | |||
| "description": "simulation engines that can use this pseudopotential" | |||
| "description": "simulation engines that can use this pseudopotential", | |||
There was a problem hiding this comment.
An Application is an object, we should clarify that this field is for the application names
timurbazhirov
approved these changes
Dec 7, 2023
timurbazhirov
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json-to-simpl-schema has issues handling empty arrays