SOF-7354: more experiment with colors x4

pranabdas · pranabdas · commit 46672f599d9e · 2024-05-14T18:37:45.000+08:00
diff --git a/src/mixins/atoms.js b/src/mixins/atoms.js
@@ -113,7 +113,7 @@ export const AtomsMixin = (superclass) =>
                     } else {
                         // odd labels
                         hue = atomHSL.h - ((label + 1) * 0.1) / 2;
-                        saturation = atomHSL.s - ((label + 1) * 0.1) / 2;
+                        saturation = atomHSL.s + ((label + 1) * 0.1) / 2;
                     }
 
                     // hue is cyclic
@@ -126,7 +126,6 @@ export const AtomsMixin = (superclass) =>
                     }
 
                     saturation = Math.max(0, Math.min(1, saturation));
-                    new THREE.Color(atomColor).setHSL(atomHSL);
                     sphereMesh.material.emissiveIntensity = 0.25;
                     sphereMesh.material.emissive.setHSL(hue, saturation, atomHSL.l);
                 }
diff --git a/tests/__tests__/__snapshots__/centos/colorsOfAtomsWithLabels.expected.png b/tests/__tests__/__snapshots__/centos/colorsOfAtomsWithLabels.expected.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:063665a3611dd987fd10a839526d9db8f8da07b911d4bbaa96f362b0144a2ee7
-size 22028
+oid sha256:148297819560b8bf41b68e6b4142a8a03bfe7d1164c645c8c5dae0985bf03026
+size 22077
diff --git a/tests/__tests__/__snapshots__/macos/colorsOfAtomsWithLabels.expected.png b/tests/__tests__/__snapshots__/macos/colorsOfAtomsWithLabels.expected.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ad38583edfb28dd0f94f306203ddedc4b6ad0b751202b38d1326eff1ed84fd56
-size 21766
+oid sha256:9272fbba02a5784bf27b7c73ab726af29a037ab1840db36e508540bb2398b4d6
+size 21791
diff --git a/tests/__tests__/__snapshots__/ubuntu/colorsOfAtomsWithLabels.expected.png b/tests/__tests__/__snapshots__/ubuntu/colorsOfAtomsWithLabels.expected.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:769153534a687dca7a45764d00f08a21d79296896b7161d2420e730b95e0295a
-size 22028
+oid sha256:0086ae13e4ab4e60f5fcd7f6b10bbf26b9ea502f3a0b5b3ed51f2c70a91b7abf
+size 22077

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ export const AtomsMixin = (superclass) =>`
`113`	`113`	`} else {`
`114`	`114`	`// odd labels`
`115`	`115`	`hue = atomHSL.h - ((label + 1) * 0.1) / 2;`
`116`		`- saturation = atomHSL.s - ((label + 1) * 0.1) / 2;`
	`116`	`+ saturation = atomHSL.s + ((label + 1) * 0.1) / 2;`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`// hue is cyclic`
`@@ -126,7 +126,6 @@ export const AtomsMixin = (superclass) =>`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`saturation = Math.max(0, Math.min(1, saturation));`
`129`		`- new THREE.Color(atomColor).setHSL(atomHSL);`
`130`	`129`	`sphereMesh.material.emissiveIntensity = 0.25;`
`131`	`130`	`sphereMesh.material.emissive.setHSL(hue, saturation, atomHSL.l);`
`132`	`131`	`}`