refactor: consolidate permissions into structured types #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: consolidate permissions into structured types
Summary
Refactored the Claude Code SDK permissions system to use cleaner, structured types instead of scattered individual fields. Added
ToolConfig
andPermissionConfig
structs to group related configuration options, following patterns observed in reference repositories like opcode.Key Changes:
ToolConfig
(withAllowed
/Disallowed
) andPermissionConfig
(withMode
/PromptTool
/DangerouslySkip
)The refactoring maintains 100% backward compatibility while providing a cleaner, more organized API for new users.
Review & Testing Checklist for Human
AllowedTools
,DisallowedTools
,PermissionMode
, etc. still works unchangedTools.Allowed
andAllowedTools
)examples/
directory compile and run without errors--allowedTools
,--permission-mode
, etc. flagsNotes
addModelAndToolArgs()
andaddPermissionArgs()
Requested by: Maria Chrysafis (@MariaChrysafis)
Link to Devin run: https://app.devin.ai/sessions/df27f367592345bd9b9cade2fcbb0e9c