Skip to content

feat: support data in both gzip and json #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: support data in both gzip and json #76

wants to merge 5 commits into from
+95 −42

Conversation

thanhdanh
Copy link

@thanhdanh thanhdanh commented Feb 20, 2025 •
edited
Loading

Summary

The mobile should work on both gzip and json URL without any issue. The enhancement in the core native is ExodusMovement/mymonero-core-cpp#39

Test plan

  • run yarn test
  • build package and test on mobile with both urls

@thanhdanh thanhdanh self-assigned this Feb 20, 2025
@thanhdanh thanhdanh marked this pull request as ready for review February 20, 2025 17:48
@thanhdanh thanhdanh requested a review from feri42 February 20, 2025 17:49
feri42
feri42 approved these changes Feb 21, 2025
View reviewed changes
Copy link

@feri42 feri42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feri42 feri42 feri42 approved these changes

Assignees

@thanhdanh thanhdanh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thanhdanh @feri42