-
Notifications
You must be signed in to change notification settings - Fork 2
Partial zeroing #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Partial zeroing #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a squash of zero's first four commits, because several changes are undone between them.
Now we can get scripts with @blob and stuff
Identical to olde ECL
Unfortunately, the type checker assumes all enum consts are ints currently so this breaks horribly
This also fixes a bug that I think existed already when using dot syntax with an undefined enum. Somehow there were no tests for this
This was zero's merge commit, but since everything on both sides up to it has been cherry-picked, this merge is a no-op.
This is NOT just a trivial merge, some doc comments have been edited, a function was changed to a const.
This helps bring some tests to a reasonable compromise
Doing so prevents roundtripping and there's no clear solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains a portion of zero's commits from #63.
This branch has been reconstructed from the common ancestor of
mainand #63.mainand Format improvements (WIP) #63, which ismainandformat_improvements_testin an order that seemed easiest to resolve.maininto it so that all of my new latest stuff is there. This branch won't be easy to rebase onto main, but it should at least be easy to merge intomainnow.After working with it, I don't think there's anything in here that I am opposed to merging. I would like to fix the test suite though and maybe add some tests for new stuff.