[UX Reliability] Improve the bottom modal animations #55157

BartoszGrajdek · 2025-01-13T11:56:34Z

Explanation of Change

This PR reimplements the library react-native-modal that we've been using for all modals but with react-native-reanimated instead of react-native-animatable inside of it.

We'll gradually switch to the new solution, going through each type of bottom-docked modals. In this PR, we're adding the refactored and changed code and implementing the new solution in FAB.

Fixed Issues

$ #49354

Tests

This PR affects just the FAB modal on native & mWeb platforms.

I think testing should go like this:

Open the modal.
Close it by clicking the backdrop.
Open the modal.
Close it through the "back" button if it exists on your device.
Open the modal.
Go through each button/option in that modal and verify that everything's functioning properly.

Offline tests

N/A - nothing should change in this case

QA Steps

Same as in the Tests section

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

Android.mWeb.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

iOS.mWeb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…-native-modal-refactor

…oszGrajdek/react-native-modal-refactor-Vkuba # Conflicts: # src/pages/home/report/ContextMenu/ContextMenuActions.tsx

…Vkuba

…act-native-modal-refactor-Vkuba adding some types, and do some refactor

fix trashold

…-native-modal-refactor

…oszGrajdek/react-native-modal-refactor_kuba_v2 # Conflicts: # src/components/Search/SearchRouter/SearchRouterModal.tsx

…oszGrajdek/react-native-modal-refactor_kuba_v2 # Conflicts: # src/components/Modal/BaseModal.tsx

@bartosz

@bartosz grajdek/react native modal refactor kuba v2

github-actions · 2025-02-17T14:11:45Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

ZhenjaHorbach · 2025-02-17T14:30:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screenrecorder-2025-02-17-16-00-10-845.mp4

Android: mWeb Chrome

Screenrecorder-2025-02-17-16-03-04-813.mp4

iOS: Native

IMG_9139.MP4

iOS: mWeb Safari

IMG_9140.MP4

MacOS: Chrome / Safari

2025-02-17.16.08.37.mov

MacOS: Desktop

2025-02-17.16.12.35.mov

github-actions · 2025-02-17T14:37:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55157/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55157/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55157/NewExpensify.dmg	https://55157.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

src/components/Modal/BottomDockedModal/Backdrop/index.web.tsx

github-actions · 2025-02-17T14:45:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55157/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55157/index.html

Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

mountiny · 2025-02-17T15:05:35Z

Looks nice and smooth on my device

@BartoszGrajdek can you please resolve merge conflicts?

ZhenjaHorbach · 2025-02-17T15:16:09Z

At first everything looks nice for me too

The only thing I noticed on the desktop is this
When a modal window is displayed in the wrong place for a split second (this is a bottom modal on mobile )

2025-02-17.16.13.57.mov

shubham1206agra · 2025-02-17T15:32:55Z

@ZhenjaHorbach This bug should be solved in #56594

BartoszGrajdek · 2025-02-17T15:36:17Z

When a modal window is displayed in the wrong place for a split second (this is a bottom modal on mobile )

This modal is not affected by these changes, the only modal that will use new code for now is FAB, we'll gradually implement the new version in other modals later.

ZhenjaHorbach · 2025-02-17T15:38:30Z

@ZhenjaHorbach This bug should be solved in #56594

Strange
But I tested it with adhoc builds that were created an hour ago

ZhenjaHorbach · 2025-02-17T15:39:09Z

This modal is not affected by these changes, the only modal that will use new code for now is FAB, we'll gradually implement the new version in other modals later.

Oh
Yeah 😅
In this case everything looks good !

mountiny · 2025-02-17T17:34:18Z

@BartoszGrajdek Conflicts have to be resolved before merging

BartoszGrajdek · 2025-02-17T18:00:06Z

Fixed @mountiny let's see if all the checks pass and it should be ready to go 😄

src/components/Modal/BottomDockedModal/Backdrop/index.web.tsx

src/components/Modal/BottomDockedModal/Backdrop/index.tsx

src/components/Modal/BottomDockedModal/Backdrop/index.web.tsx

src/components/Modal/BottomDockedModal/Backdrop/index.tsx

src/components/Modal/BottomDockedModal/index.tsx

src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

mountiny

Lets test this out!

OSBotify · 2025-02-18T12:05:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-19T03:40:52Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

mvtglobally · 2025-02-19T14:38:48Z

Team is facing #57081 when running this PR

github-actions · 2025-02-20T02:48:29Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.1-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

BartoszGrajdek and others added 29 commits November 6, 2024 11:39

feat: change modal animation library

fb2f774

Merge remote-tracking branch 'origin/main' into @BartoszGrajdek/react…

1d83349

…-native-modal-refactor

adding some types, and do some refactor

442b29d

working on null handling and linter problems

0770e20

Merge branch '@BartoszGrajdek/react-native-modal-refactor' into @Bart…

51e30ab

…oszGrajdek/react-native-modal-refactor-Vkuba # Conflicts: # src/pages/home/report/ContextMenu/ContextMenuActions.tsx

fix types and build error

fed11de

fix linters problems

e51ff8a

fix typo in TransactionType

61d4bf3

fix permissions issue

e7b1bb5

fix issue with to little height of container

2d43ab0

Merge branch 'main' into @BartoszGrajdek/react-native-modal-refactor-…

ed4e2e9

…Vkuba

fix problem with no handling gestures

3ad4eab

Merge pull request #133 from software-mansion-labs/@BartoszGrajdek/re…

1e78131

…act-native-modal-refactor-Vkuba adding some types, and do some refactor

refactor: ts & eslint cleanup

fc04fa1

add callbacks to animations instead of timeout

ad079da

fix hideModalContentWhileAnimating

dd1ff93

work in progress on any types

96de617

fix emoji picker tab

b2ab25c

add swipe animations using react reanimate

5c2b0f6

refactor and clean code

a95e496

Update SearchRouterModal.tsx

d9d2df3

fix trashold

changes from Bartek CR

6ac6696

Merge remote-tracking branch 'origin/main' into @BartoszGrajdek/react…

525f9ca

…-native-modal-refactor

Merge branch '@BartoszGrajdek/react-native-modal-refactor' into @Bart…

50ea848

…oszGrajdek/react-native-modal-refactor_kuba_v2 # Conflicts: # src/components/Search/SearchRouter/SearchRouterModal.tsx

feat: add handling for different modal types

61f207a

Merge branch '@BartoszGrajdek/react-native-modal-refactor' into @Bart…

dee6299

…oszGrajdek/react-native-modal-refactor_kuba_v2 # Conflicts: # src/components/Modal/BaseModal.tsx

fix merge problems

0312e11

Modal code refactor

afcb7db

@bartosz grajdek/react native modal refactor kuba v2

[49354] Migrate react-native-modal to reanimated

17fbefe

BartoszGrajdek changed the title ~~@bartosz grajdek/react native modal refactor~~ Bottom Docked Modals Improvements Jan 13, 2025

mountiny requested a review from ZhenjaHorbach February 17, 2025 14:29

ZhenjaHorbach reviewed Feb 17, 2025

View reviewed changes

src/components/Modal/BottomDockedModal/Backdrop/index.web.tsx Outdated Show resolved Hide resolved

ZhenjaHorbach approved these changes Feb 17, 2025

View reviewed changes

blazejkustra approved these changes Feb 17, 2025

View reviewed changes

chore: resolve merge conflicts

caa8d4e

mountiny requested changes Feb 18, 2025

View reviewed changes

refactor: move animation timing to CONST & add display names

4d87305

mountiny approved these changes Feb 18, 2025

View reviewed changes

mountiny merged commit 4088726 into Expensify:main Feb 18, 2025
16 checks passed

github-actions bot mentioned this pull request Feb 19, 2025

Deploy Checklist: New Expensify 2025-02-19 #57066

Closed

56 tasks

This was referenced Feb 21, 2025

Update Android and IOS download link to Hybrid App #57226

Merged

feat: update Search/Reports page immediately following report actions #56772

Closed

nkdengineer mentioned this pull request Feb 22, 2025

[Due for payment 2025-03-17] [Due for payment 2025-03-13] [$250] iOS - Search - Search page cannot be dismissed by swiping to the right #57291

Closed

8 tasks

BartoszGrajdek mentioned this pull request Feb 27, 2025

Invisible view on FAB using refactored modal fix #57536

Merged

49 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UX Reliability] Improve the bottom modal animations #55157

[UX Reliability] Improve the bottom modal animations #55157

BartoszGrajdek commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Feb 17, 2025

ZhenjaHorbach commented Feb 17, 2025 •

edited

Loading

github-actions bot commented Feb 17, 2025

github-actions bot commented Feb 17, 2025

mountiny commented Feb 17, 2025

ZhenjaHorbach commented Feb 17, 2025 •

edited

Loading

shubham1206agra commented Feb 17, 2025

BartoszGrajdek commented Feb 17, 2025

ZhenjaHorbach commented Feb 17, 2025

ZhenjaHorbach commented Feb 17, 2025 •

edited

Loading

mountiny commented Feb 17, 2025

BartoszGrajdek commented Feb 17, 2025

mountiny left a comment

OSBotify commented Feb 18, 2025

github-actions bot commented Feb 19, 2025

mvtglobally commented Feb 19, 2025

github-actions bot commented Feb 20, 2025

[UX Reliability] Improve the bottom modal animations #55157

[UX Reliability] Improve the bottom modal animations #55157

Conversation

BartoszGrajdek commented Jan 13, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Feb 17, 2025

ZhenjaHorbach commented Feb 17, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

github-actions bot commented Feb 17, 2025

github-actions bot commented Feb 17, 2025

mountiny commented Feb 17, 2025

ZhenjaHorbach commented Feb 17, 2025 • edited Loading

shubham1206agra commented Feb 17, 2025

BartoszGrajdek commented Feb 17, 2025

ZhenjaHorbach commented Feb 17, 2025

ZhenjaHorbach commented Feb 17, 2025 • edited Loading

mountiny commented Feb 17, 2025

BartoszGrajdek commented Feb 17, 2025

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 18, 2025

github-actions bot commented Feb 19, 2025

mvtglobally commented Feb 19, 2025

github-actions bot commented Feb 20, 2025

BartoszGrajdek commented Jan 13, 2025 •

edited

Loading

ZhenjaHorbach commented Feb 17, 2025 •

edited

Loading

ZhenjaHorbach commented Feb 17, 2025 •

edited

Loading

ZhenjaHorbach commented Feb 17, 2025 •

edited

Loading