-
Notifications
You must be signed in to change notification settings - Fork 3.6k
refactor: Migrate "Add Attachment" flows to AttachmentModalScreen
#69523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mountiny
merged 45 commits into
Expensify:main
from
margelo:@chrispader/add-attachment-modal-refactor
Oct 8, 2025
Merged
Changes from 43 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
be9b2b9
refactor: migrate 'Add Attachment' flows to AttachmentModalScreen
chrispader 25471a5
Merge branch 'main' into @chrispader/add-attachment-modal-refactor
chrispader 96d4dd5
fix: add ReportAddAttachmentModal route
chrispader 2cfac05
fix: remove validation logic in ReportAttachmentModalContent
chrispader 000fd32
fix: remove onConfirm callback from ReportAttachmentModalContent
chrispader 667ef39
fix: ReportAttachmentModalContent
chrispader d8b1bb9
fix: wrong screen name
chrispader 89b9b1a
refactor: simplify threeDotsMenuItems prop implementation
chrispader 844976a
Merge branch 'main' into @chrispader/add-attachment-modal-refactor
chrispader 358dd96
Merge branch 'main' into @chrispader/add-attachment-modal-refactor
chrispader 248939d
fix: integrate file upload validation into useFilesValidation
chrispader c9351f2
refactor: rename CONST keys for AttachmentModal validation errors
chrispader c55551b
fix: error modal not shown
chrispader 6178d2b
Merge branch 'main' into @chrispader/add-attachment-modal-refactor
chrispader 6c02057
rename test names
chrispader 2afa420
refactor: move `validateAttachment` logic to `AttachmentValidation` lib
chrispader 4a63bd4
test: update tests according to changes in FileUtils
chrispader ca2820d
fix: attachment file validation
chrispader d4ac8be
refactor: move CONST keys for more order
chrispader 0adee50
feat: check for HEIC or HEIF image errors
chrispader e3955ce
refactor: remove unnecessary prop
chrispader 4100f35
feat: add files to validation results
chrispader beb2ded
refactor: useFilesValidation
chrispader 829e146
Merge branch 'main' into @chrispader/add-attachment-modal-refactor
chrispader 34f848e
refactor: revert attachment validation changes
chrispader 2896fff
fix: TS error and improve isPdfFile function
chrispader 5d682e5
fix: invalid prop
chrispader 6484736
Merge branch 'main' into @chrispader/add-attachment-modal-refactor
chrispader 1133d83
Merge branch 'main' into @chrispader/add-attachment-modal-refactor
chrispader 438d06d
fix: add missing displayName
chrispader 68d6ffe
Merge branch 'main' into @chrispader/add-attachment-modal-refactor
chrispader bfae2ab
refactor: move attachment validation to ReportActionCompose
chrispader 1987deb
refactor: replace ExtraModels prop with ExtraContent in container
chrispader 4f45a88
Merge branch 'main' into @chrispader/add-attachment-modal-refactor
chrispader e15abfc
fix: file validation and source extraction in "Add attachment"
chrispader 1adcbcc
Merge branch 'main' into @chrispader/add-attachment-modal-refactor
chrispader 3080cd3
fix: allow pasting multiple files
chrispader 32259c9
Merge branch 'main' into @chrispader/add-attachment-modal-refactor
chrispader 376ae6d
refactor: rename onPasteFile prop
chrispader 852b073
fix: don't validate receipts by default
chrispader c32652e
Merge branch 'main' into @chrispader/add-attachment-modal-refactor
chrispader 905e232
Merge branch 'main' into pr/69523
chrispader 80a2d46
fix: add missing `isAttachmentLoaded` logic
chrispader aa0443b
Merge branch 'main' into @chrispader/add-attachment-modal-refactor
chrispader 605f622
refactor: prefer early return
chrispader File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now allows pasting multiple files from clipboard into the Composer