Fix viewport is scrolled in some pages on iOS mWeb

[bernhardoj]

Explanation of Change

Fixed Issues

$ #67351
PROPOSAL: #67351 (comment)

Tests

Prerequisite: have more than 15 workspaces

Only for mWeb/iOS/Android

1. Open Workspaces list page
2. Focus on the search input. Make sure the keyboard is shown
3. Search anything so that only 1 WS show
4. Verify the page is not scrollable

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[bernhardoj]

Recording for the other pages:

ios.mweb.mp4

[bernhardoj]

Having trouble running the Android

[sobitneupane]

@bernhardoj We currently close the keyboard for all lists except Workspace. Do you know why that is? Could we also close it on the Workspace page? I think we’ve discussed this before.

[sobitneupane]

After the keyboard is opened, some padding is added above it.

Screen.Recording.2025-09-23.at.19.19.09.mov

[sobitneupane]

Some part of the last workspace is cut off by the keyboard.

Screen.Recording.2025-09-23.at.19.08.41.mov

[bernhardoj]

@sobitneupane Sorry for missing this.

We currently close the keyboard for all lists except Workspace. Do you know why that is? Could we also close it on the Workspace page? I think we’ve discussed this before.

You mean close the keyboard while scrolling? We close on scrolling when using SelectionList.

App/src/components/SelectionListWithSections/index.tsx

Lines 59 to 65 in 3e4193a

	const defaultOnScroll = () => {
	// Only dismiss the keyboard whenever the user scrolls the screen or `shouldHideKeyboardOnScroll` is true
	if (!isScreenTouched || !shouldHideKeyboardOnScroll) {
	return;
	}
	Keyboard.dismiss();
	};

But the WS list page uses FlatList.

App/src/pages/workspace/WorkspacesListPage.tsx

Lines 568 to 580 in 3e4193a

	<FlatList
	ref={flatlistRef}
	data={filteredWorkspaces}
	onScrollToIndexFailed={(info) => {
	flatlistRef.current?.scrollToOffset({
	offset: info.averageItemLength * info.index,
	animated: true,
	});
	}}
	renderItem={getMenuItem}
	ListHeaderComponent={listHeaderComponent}
	keyboardShouldPersistTaps="handled"
	/>

Should we add onScroll and dismiss the keyboard too?

After the keyboard is opened, some padding is added above it.

I can't reproduce this one, but most likely it's the viewport autoscroll of Safari.

Some part of the last workspace is cut off by the keyboard.

Can't repro this one either.

[bernhardoj]

@sobitneupane bump

[sobitneupane]

Should we add onScroll and dismiss the keyboard too?

I think it makes sense for consistency. What do you think?

I'll try reproducing the other issues and update you soon.

[sobitneupane]

I can still reproduce this issue on mWeb/Safari. @bernhardoj Could you please test it again?

Screen.Recording.2025-10-07.at.14.56.16.mov

I can still reproduce this issue on IOS/native. However, this should no longer be a problem once we implement this fix.

Screen.Recording.2025-10-07.at.15.03.06.mov

@bernhardoj Both issues are consistently reproducible on my end. These issues are not reproducible in main.

[bernhardoj]

I can reproduce the first issue now. It also happens on main and staging.

ios.mweb.mp4

The 2nd issue also happens on main.

ios.mp4

I think it makes sense for consistency. What do you think?

I'm not 100% sure. I think it's best to replace the FlatList to SelectionList if we want the keyboard dismiss on scroll behavior (but I'm afraid this would cause regressions). Otherwise, we need to create a hook(?) to DRY up the logic and create a separate native and non native files.

[sobitneupane]

In this issue, I am talking about the highlighted area (spacing above the keyboard). I can not reproduce it on main.

[sobitneupane]

I'm not 100% sure. I think it's best to replace the FlatList to SelectionList if we want the keyboard dismiss on scroll behavior (but I'm afraid this would cause regressions). Otherwise, we need to create a hook(?) to DRY up the logic and create a separate native and non native files.

In that case, let's focus on the issue described in the OP.

[sobitneupane]

The 2nd issue also happens on main.

I was also able to reproduce the issue on main. 👍

[sobitneupane]

Bump @bernhardoj

[bernhardoj]

In #70643 (comment) issue, I am talking about the highlighted area (spacing above the keyboard). I can not reproduce it on main.

Ah, I see. That happens because of the shouldEnableMaxHeight. It happens to all components that use it. For example,

[bernhardoj]

@sobitneupane bump

[sobitneupane]

Sorry for the delay @bernhardoj

It’s been a busy week, but I’ll do my best to get it done by the weekend.

[sobitneupane]

@bernhardoj I could not reproduce this issue on staging.

[sobitneupane]

Before	After

[bernhardoj]

Just rechecked and yeah it doesn't happen on that currency page. This only happens when we focus on the text input and the viewport is automatically scrolled.

This is just to show that it could happens to any page with shouldEnableMaxHeight and the input is positioned in a position that when focused, will trigger the viewport scroll.

ios.a.mp4

[sobitneupane]

Thanks for the update, @bernhardoj.

Why do we auto-scroll the viewport on Workspace feature pages?

Merging the PR as it is will introduce a regression in these pages. I believe we should address the issue here before proceeding.

[bernhardoj]

Why do we auto-scroll the viewport on Workspace feature pages?

That's the iOS Safari behavior.

I don't have a fix for that. If we want to fix it, then it's better to have a new issue for that.

Here is another example where this issue happens.

ios.mweb.mp4

We actually have a workaround here to scroll the viewport back to 0, but not sure why it doesn't work reliably. Log doesn't show in my Safari Inspector, so I can't investigate it.

App/src/hooks/useTackInputFocus/index.ts

Lines 37 to 48 in 0171f0a

	const resetScrollPositionOnVisualViewport = () => {
	if (isChromeIOS() && window.visualViewport?.offsetTop) {
	// On Chrome iOS, the visual viewport triggers a scroll event when the keyboard is opened, but some time the scroll position is not correct.
	// So this change is specific to Chrome iOS, helping to reset the viewport position correctly.
	window.scrollTo({top: -window.visualViewport.offsetTop});
	} else {
	window.scrollTo({top: 0});
	}
	};
	window.addEventListener('focusin', handleFocusIn);
	window.addEventListener('focusout', handleFocusOut);
	window.visualViewport?.addEventListener('scroll', resetScrollPositionOnVisualViewport);

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/workspace/WorkspacesListPage.tsx	73.15% <ø> (ø)
...s/workspace/categories/WorkspaceCategoriesPage.tsx	60.07% <ø> (ø)
...orkspace/distanceRates/PolicyDistanceRatesPage.tsx	0.00% <ø> (ø)
...c/pages/workspace/perDiem/WorkspacePerDiemPage.tsx	0.00% <ø> (ø)
src/pages/workspace/tags/WorkspaceTagsPage.tsx	47.09% <ø> (ø)
src/pages/workspace/taxes/WorkspaceTaxesPage.tsx	0.00% <ø> (ø)
... and 12 files with indirect coverage changes

[sobitneupane]

@bernhardoj Are you able to consistently reproduce the issue you mentioned #70643 (comment) ? I was only able to reproduce it once, and that was only when the user was offline.

I’d like to get this resolved before merging the PR. If you have reliable reproduction steps, we can create a dedicated issue and address it before moving forward with the merge.

[bernhardoj]

Yes, online or offline.

[sobitneupane]

@bernhardoj If you’re able to reproduce the issue consistently, could you please report the bug and share the link here? I haven’t been able to reproduce it reliably on my end.

[bernhardoj]

Reported here: https://expensify.slack.com/archives/C049HHMV9SM/p1762418837629929

[bernhardoj]

@sobitneupane Here is the issue: #74559

[sobitneupane]

I'm keeping a close eye on that issue. There aren't any proposals yet. I think we can merge this PR once we confirm that the solution in #74559 actually fixes the problem here.

[sobitneupane]

Same as above — no progress yet on the linked issue.

[sobitneupane]

PR on HOLD

Same as above — no progress yet on the linked issue.

[bernhardoj]

@sobitneupane the other PR is merged. This issue is now fixed.

[JmillsExpensify]

No product concerns from me.