fix: Receipt validation not working in drag&drop section of report screen (AFTER REVERT)#73238
Conversation
melvin-bot
bot
requested review from
Beamanator
and removed request for
a team
|
@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
MariaHCD
requested review from
MarioExpensify and
parasharrajat
and removed request for
Beamanator
src/libs/fileDownload/FileUtils.ts
Outdated
|
|
||
| type ValidateAttachmentOptions = { | ||
| isValidatingReceipts?: boolean; | ||
| isCheckingMultipleFiles?: boolean; |
There was a problem hiding this comment.
Canges in this file are unrelated to the fix and just a refactor to make the parameter more consistent with other parts of this logic
MariaHCD
changed the title
tests/unit/FileUtilsTest.ts
Outdated
| describe('validateAttachment', () => { | ||
| it('should not return FILE_TOO_SMALL when validating small attachment', () => { | ||
| const file = createMockFile('file.csv', CONST.API_ATTACHMENT_VALIDATIONS.MIN_SIZE - 1); | ||
| const error = FileUtils.validateAttachment(file, {isCheckingMultipleFiles: false, isValidatingReceipts: false}); |
Codecov Report❌ Patch coverage is
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Reviewer Checklist
Screenshots22.10.2025_23.39.36_REC.mp4 |
|
BUG: Unable to add multiple receipts via drag and drop when one of the receipt is video. 22.10.2025_23.46.41_REC.mp4 |
|
BUG: Able to upload Video as receipt while submitting expense. |
@parasharrajat i'm unable to repro this. What are the exact steps? Screen.Recording.2025-10-22.at.19.32.47.mov |
chrispader
dismissed stale reviews from MarioExpensify and MariaHCD
via
ee106ad
chrispader
changed the title
chrispader
changed the title
|
So I tried following.
|
|
BUG: SVG is allowed as receipt. |
|
@chrispader I think there is some issue on your validations. It is not following same validation as it used to do earlier. Can you please check receipt validation logic on why it allows some files which it is not supposed to |
|
Can't reproduce this either. may be a bad state. |
…s = true` by default
@parasharrajat both of these (and probably also other errors) should be fixed now. This was my bad, i've removed the default fallback behavior to validate receipts. I added this back now, so other parts of the app should be unaffected! |
|
@parasharrajat my recent changes actually also fix an issue in |
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable @typescript-eslint/no-deprecated */ | |||
There was a problem hiding this comment.
Thanks for the catch!
There was a problem hiding this comment.
@parasharrajat Actually we do need this, my bad. I don't see that usages of translateLocal we're removed from this file
Screenshots🔲 iOS / native28.10.2025_02.54.56_REC.mp4🔲 iOS / Safari28.10.2025_02.53.14_REC.mp4🔲 MacOS / Desktop21.10.2025_06.37.23_REC.mp4🔲 MacOS / Chrome28.10.2025_00.35.47_REC.mp4🔲 Android / Chrome28.10.2025_02.35.56_REC.mp4🔲 Android / native28.10.2025_02.32.40_REC.mp4 |
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
@chrispader Please merge main to solve check failure. |
Performance Review Issues Found❌ PERF-4: Memoize objects and functions passed as propsFile: src/hooks/useFilesValidation.tsx Fix: Restore the useCallback memoization with proper dependencies: [fileError, invalidFileExtension, isValidatingReceipts, translate] ✅ Other Changes Look GoodThe other changes in this PR appear to follow good practices:
The spread operator usage in validationOptionsWithDefaults is acceptable as it's not in a renderItem context and creates objects efficiently. |
HelpDot Documentation ReviewOverall AssessmentThis PR contains no documentation changes - it consists entirely of code modifications to improve file attachment validation functionality. All changed files are TypeScript implementation files and unit tests focused on refactoring the useFilesValidation hook and related utilities. Files ReviewedThe PR modifies 4 files, all of which are code files:
Documentation ImpactNo documentation review needed - This is a technical refactoring PR that:
RecommendationSince this PR contains no documentation changes, no documentation quality assessment is applicable. The code changes appear well-structured and maintain backwards compatibility while improving the internal API design. Note: This automated review found no documentation files to assess. For code-only PRs like this one, documentation review is not applicable. |
| : undefined; | ||
|
|
||
| const getModalPrompt = useCallback(() => { | ||
| const getModalPrompt = () => { |
There was a problem hiding this comment.
Why did you remove the useCallback here?
There was a problem hiding this comment.
Because the file can be successfully compiled with React Compiler and therefore we can remove manual memoization like in other callbacks.
Now on a second look, there are still some usages of useCallback, which can be removed. Are we good with allowing React Compiler to do it's thing in this hook? @mountiny
There was a problem hiding this comment.
Ah ok that makes sense. Thanks! @adamgrzybowski @kacper-mikolajczak Seems like we will need to tweak the AI reviewer to acknoledge this though I am not sure how easy it will be so the reviewer knows if the file is compilable with the react compiler
| : undefined; | ||
|
|
||
| const getModalPrompt = useCallback(() => { | ||
| const getModalPrompt = () => { |
There was a problem hiding this comment.
Ah ok that makes sense. Thanks! @adamgrzybowski @kacper-mikolajczak Seems like we will need to tweak the AI reviewer to acknoledge this though I am not sure how easy it will be so the reviewer knows if the file is compilable with the react compiler
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.2.41-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.41-6 🚀
|
6 participants
@MarioExpensify @parasharrajat
Explanation of Change
Adapts the attachment file validation to allow using it for attachments and receipts at the same time.
Fixed Issues
$ #72402
$ #73180
PROPOSAL:
Tests
.mp4) in the right side (Scan receipt) of the Drag&Drop zone of the composerOffline tests
None needed.
QA Steps
Same as in Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-10-16.at.15.07.23.mov
Screen.Recording.2025-10-16.at.15.07.23.mov
MacOS: Desktop