Skip to content

[No QA] [HelpDot] Add details on how to freeze or unfreeze an Expensify Card for cardholders#80723

Merged
MariaHCD merged 3 commits intomainfrom
maria-helpdot-freeze-card-cardholder
Apr 13, 2026
Merged

[No QA] [HelpDot] Add details on how to freeze or unfreeze an Expensify Card for cardholders#80723
MariaHCD merged 3 commits intomainfrom
maria-helpdot-freeze-card-cardholder

Conversation

@MariaHCD
Copy link
Copy Markdown
Contributor

@MariaHCD MariaHCD commented Jan 28, 2026

Explanation of Change

Fixed Issues

Part of https://github.com/Expensify/Expensify/issues/593794

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@MariaHCD MariaHCD self-assigned this Jan 28, 2026
@github-actions github-actions bot changed the title [HelpDot] Add details on how to freeze or unfreeze an Expensify Card for cardholders [No QA] [HelpDot] Add details on how to freeze or unfreeze an Expensify Card for cardholders Jan 28, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jan 28, 2026

A preview of your ExpensifyHelp changes have been deployed to https://53980d4d.helpdot.pages.dev ⚡️

Updated articles:

CortneyOfstad
CortneyOfstad previously approved these changes Mar 11, 2026
@MariaHCD MariaHCD marked this pull request as ready for review April 10, 2026 08:47
@MariaHCD MariaHCD removed the request for review from stephanieelliott April 10, 2026 08:47
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new section on freezing/unfreezing an Expensify Card to the existing Cardholder Settings and Features article. The content is clear and useful, but several governance violations need to be addressed before merge.

Scores Summary

  • Readability: 7/10 - The steps are clear and the bullet lists explaining freeze behavior are helpful. However, inconsistent verb usage ("Click" in step 1 vs. "Tap" in step 3) and the vague term "popup modal" reduce clarity.
  • AI Readiness: 5/10 - The new section heading (# Freeze or unfreeze your Expensify Card) lacks a task-based verb (should start with "How to"). A ### heading is used, which is forbidden. The heading hierarchy does not comply with the two-level (# and ##) requirement.
  • Style Compliance: 6/10 - Button names are correctly bolded (Freeze card, Unfreeze card). However, there is inconsistent action verb usage (mixing "Click" and "Tap" within the same instruction set), and "popup modal" is not exact UI terminology.

Key Findings

Must fix:

  • The ### To freeze or unfreeze your card: heading uses ###, which is forbidden. Per HELP_AUTHORING_GUIDELINES.md Section 4 and Section 9, only # and ## headings are permitted. This should be converted to a ## heading or removed entirely (folding the steps directly under the # section).
  • The ### To freeze or unfreeze your card: heading also ends with a colon, which is non-standard for documentation headings.
  • The # Freeze or unfreeze your Expensify Card heading should be task-based per governance rules. Recommended: # How to freeze or unfreeze your Expensify Card.
  • Steps mix "Click" (step 2) and "Tap" (step 3) without platform context. Use consistent verbs, or if distinguishing platforms, provide separate Web/Mobile instructions per HELPSITE_NAMING_CONVENTIONS.md navigation standards.

Should fix:

  • "Confirm in the popup modal" (step 4) uses vague terminology. Reference the exact UI element or button name (e.g., "Click Confirm" or whatever the actual button label is).
  • The "Note:" at the end should clarify the specific action ("contact them directly via chat" is somewhat vague -- consider specifying Expensify Chat or the exact mechanism).

Positive aspects:

  • Good use of bold formatting for button names (Freeze card, Unfreeze card, Frozen).
  • The introductory bullets clearly explain what freezing does and does not do, which is helpful for users and AI retrieval.
  • Navigation instruction in step 1 correctly follows the unified format for web/mobile.

Recommendations

  1. [Required] Change ### heading to ## or remove it, folding the steps under the parent section heading.
  2. [Required] Make the section heading task-based: # How to freeze or unfreeze your Expensify Card.
  3. [Required] Use consistent action verbs across all steps (do not mix "Click" and "Tap" without platform separation).
  4. [Recommended] Replace "popup modal" with the exact UI button label shown in the confirmation dialog.
  5. [Recommended] Consider adding this section's keywords to the article-level YAML keywords array (e.g., "freeze card", "unfreeze card") to improve search discoverability.

Files Reviewed

  • docs/articles/new-expensify/expensify-card/Cardholder-Settings-and-Features.md - 24 lines added. New section on freezing/unfreezing Expensify Card. Has heading hierarchy and style compliance issues that need correction.

Review based on docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md governance standards.

@MariaHCD
Copy link
Copy Markdown
Contributor Author

MariaHCD commented Apr 10, 2026

@MelvinBot given the review suggestions in #80723 (comment), update this PR to comply with our guidelines

- Make section heading task-based ("How to freeze or unfreeze")
- Change ### to ## (only # and ## headings permitted)
- Remove colon from subheading
- Use consistent "Click" verb instead of mixing Click/Tap
- Replace vague "popup modal" with "dialog that appears" and specific button name
- Specify "Expensify Chat" instead of generic "via chat"
- Add freeze/unfreeze keywords to YAML frontmatter

Co-authored-by: Maria D'Costa <[email protected]>
@MelvinBot
Copy link
Copy Markdown
Contributor

Updated the PR to address the review suggestions:

  • Heading hierarchy: Changed ### to ## (only # and ## are permitted) and removed trailing colon
  • Task-based heading: Renamed # Freeze or unfreeze your Expensify Card# How to freeze or unfreeze your Expensify Card
  • Consistent verbs: Changed "Tap" to "Click" in step 3 to match the rest of the article
  • Specific UI terminology: Replaced "Confirm in the popup modal" with "Click Confirm in the dialog that appears"
  • Specific chat reference: Changed "via chat" to "via Expensify Chat"
  • Keywords: Added freeze card and unfreeze card to YAML frontmatter for search discoverability

@MariaHCD MariaHCD requested a review from CortneyOfstad April 10, 2026 09:14
@MariaHCD MariaHCD merged commit 3c1aa13 into main Apr 13, 2026
18 checks passed
@MariaHCD MariaHCD deleted the maria-helpdot-freeze-card-cardholder branch April 13, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants