Refactor add personal bank account to use useSubPage by bernhardoj · Pull Request #81333 · Expensify/App

bernhardoj · 2026-02-03T17:10:54Z

HELD on Refactor netsuite connection page to use useSubPage #80711

Explanation of Change

Fixed Issues

$ #79041
Part of #59245
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Go to the Account > Wallet > Add bank account
Play around the navigation by going next and back using the app, browser, or device back gesture/button
Verify the navigation works correctly
On the confirmation page, press any of the fields to edit it
Then, press Confirm to save the edit
Verify it goes back to the confirm page
Press Confirm to add it
Verify it goes to the Success page
Press Confirm or back
Verify it closes the success page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

melvin-bot · 2026-02-03T17:11:02Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3406d257a4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/settings/Wallet/InternationalDepositAccount/InternationalDepositAccountContent.tsx

codecov · 2026-02-03T17:21:11Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.56% <ø> (ø)`
...lDepositAccount/subPages/AccountFlowEntryPoint.tsx	`0.00% <ø> (ø)`
...tionalDepositAccount/subPages/CountrySelection.tsx	`0.00% <ø> (ø)`
...t/InternationalDepositAccount/subPages/Success.tsx	`0.00% <ø> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`7.40% <0.00%> (ø)`
...ternationalDepositAccount/subPages/AccountType.tsx	`0.00% <0.00%> (ø)`
...onalDepositAccount/subPages/BankAccountDetails.tsx	`0.00% <0.00%> (ø)`
src/ROUTES.ts	`13.74% <0.00%> (-0.04%)`	⬇️
...ernationalDepositAccount/subPages/Confirmation.tsx	`0.00% <0.00%> (ø)`
...positAccount/subPages/AccountHolderInformation.tsx	`0.00% <0.00%> (ø)`
... and 3 more
... and 9 files with indirect coverage changes

dukenv0307 · 2026-02-04T02:30:00Z

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

@bernhardoj can we add more unit tests?

dukenv0307 · 2026-02-04T03:49:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-04.at.11.09.45.mov

Android: mWeb Chrome

Screen.Recording.2026-02-04.at.10.47.15.mov

iOS: HybridApp

Screen.Recording.2026-02-04.at.10.44.08.mov

iOS: mWeb Safari

Screen.Recording.2026-02-04.at.10.41.29.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-04.at.09.35.59.mov

bernhardoj · 2026-02-04T04:08:38Z

@dukenv0307 hmm, this is just a refactoring PR, also we don't need unit test for ROUTES and CONST

dukenv0307

LGTM

arosiclair

LGTM, waiting on other refactors to deploy first

…-use-usesubpage

dukenv0307 · 2026-02-24T02:10:34Z

@bernhardoj I think we can remove the hold label

…-use-usesubpage

arosiclair

Can we fix the country page sliding in from the left after the spinner here? It should slide in from the right

Screen.Recording.2026-02-25.at.10.57.49.AM.mov

dukenv0307 · 2026-02-26T02:38:17Z

Half of the background is transparent after selecting the country

Screen.Recording.2026-02-26.at.09.35.46.mov

dukenv0307 · 2026-02-26T02:39:33Z

The rest looks good

…-use-usesubpage

bernhardoj · 2026-02-26T09:25:24Z

Can we fix the country page sliding in from the left after the spinner here? It should slide in from the right

If we don't replace the current page, then it will slide in from the right.

App/src/hooks/useSubPage/index.tsx

Line 35 in 24fd24e

Navigation.navigate(buildRoute(startPageName), {forceReplace: true});

I think we should create a new issue and fix this replace behavior.

Half of the background is transparent after selecting the country

Fixed

…-use-usesubpage

bernhardoj · 2026-02-27T14:54:28Z

Fixed

web.mp4

dukenv0307 · 2026-02-27T15:21:39Z

@bernhardoj can you please fix the lint error?

dukenv0307 · 2026-02-27T16:30:50Z

Screen.Recording.2026-02-27.at.23.19.41.mov

Screen.Recording.2026-02-27.at.23.29.42.mov

Screen.Recording.2026-02-27.at.23.36.21.mov

dukenv0307 · 2026-02-27T16:31:14Z

Looks good

…-use-usesubpage

bernhardoj · 2026-02-28T04:03:35Z

@dukenv0307 Fixed

OSBotify · 2026-03-02T17:23:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-02T17:27:57Z

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-02T17:33:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81333.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c11a7e9-81ea079-754218795e9fedf8c7e2ccf3778924f8353c8ae4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c11a7e9-81ea079-4202b8dde1532f1b29d125a4d54f47825702aea8/index.html

Web 🕸️
https://81333.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-02T23:01:26Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.3.28-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mitarachim · 2026-03-03T03:13:37Z

@bernhardoj This PR is failing because of a regression issue #83978

The issue is reproducible in: Web

Bug7092397_1772506915518.ExpensifyWrongRedirection.mp4

OSBotify · 2026-03-04T03:16:14Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.3.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:06:35Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

refactor to use useSubPage

3406d25

bernhardoj requested review from a team as code owners February 3, 2026 17:10

melvin-bot bot assigned bernhardoj Feb 3, 2026

melvin-bot bot requested review from dukenv0307 and trjExpensify and removed request for a team and trjExpensify February 3, 2026 17:10

chatgpt-codex-connector bot reviewed Feb 3, 2026

View reviewed changes

src/pages/settings/Wallet/InternationalDepositAccount/InternationalDepositAccountContent.tsx Outdated Show resolved Hide resolved

lint

a155a72

dukenv0307 approved these changes Feb 4, 2026

View reviewed changes

melvin-bot bot requested a review from arosiclair February 4, 2026 04:10

arosiclair previously approved these changes Feb 4, 2026

View reviewed changes

arosiclair changed the title ~~Refactor add personal bank account to use useSubPage~~ [HOLD] Refactor add personal bank account to use useSubPage Feb 4, 2026

arosiclair changed the title ~~[HOLD] Refactor add personal bank account to use useSubPage~~ [HOLD #80354] Refactor add personal bank account to use useSubPage Feb 4, 2026

arosiclair changed the title ~~[HOLD #80354] Refactor add personal bank account to use useSubPage~~ [HOLD #80711] Refactor add personal bank account to use useSubPage Feb 4, 2026

arosiclair mentioned this pull request Feb 4, 2026

Refactor Netsuite import custom list to use useSubPage #80995

Merged

53 tasks

bernhardoj added 2 commits February 16, 2026 15:16

Merge branch 'main' into chore/79041-refactor-add-personal-ba-page-to…

c6a21c1

…-use-usesubpage

rename

07004c6

bernhardoj dismissed arosiclair’s stale review via 07004c6 February 16, 2026 07:22

rename

4a4b665

bernhardoj changed the title ~~[HOLD #80711] Refactor add personal bank account to use useSubPage~~ Refactor add personal bank account to use useSubPage Feb 24, 2026

Merge branch 'main' into chore/79041-refactor-add-personal-ba-page-to…

aa77b4c

…-use-usesubpage

arosiclair reviewed Feb 25, 2026

View reviewed changes

bernhardoj added 2 commits February 26, 2026 17:13

Merge branch 'main' into chore/79041-refactor-add-personal-ba-page-to…

710cfab

…-use-usesubpage

fix loading has transparent bg

3e8bce8

bernhardoj added 3 commits February 26, 2026 18:55

prettier

8b57259

Merge branch 'main' into chore/79041-refactor-add-personal-ba-page-to…

a2ccda7

…-use-usesubpage

change the animation type

b9e9fa4

bernhardoj added 2 commits February 28, 2026 11:54

Merge branch 'main' into chore/79041-refactor-add-personal-ba-page-to…

d6f64ec

…-use-usesubpage

add sentry label

7077394

dukenv0307 approved these changes Mar 2, 2026

View reviewed changes

melvin-bot bot requested a review from arosiclair March 2, 2026 01:34

arosiclair approved these changes Mar 2, 2026

View reviewed changes

arosiclair merged commit c11a7e9 into Expensify:main Mar 2, 2026
30 checks passed

OSBotify mentioned this pull request Mar 2, 2026

Deploy Checklist: New Expensify 2026-03-02 #83947

Closed

mitarachim mentioned this pull request Mar 3, 2026

[$250] Add BA - Browser back button is redirecting to confirmation page from success page #83978

Open

7 tasks

jponikarchuk mentioned this pull request Mar 3, 2026

[$250] Bank account - Tapping device back button directs user to "where's your bank account located" page #84015

Open

7 tasks

Conversation

bernhardoj commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov bot commented Feb 3, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dukenv0307 commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

bernhardoj commented Feb 4, 2026

Uh oh!

dukenv0307 left a comment

Choose a reason for hiding this comment

Uh oh!

arosiclair left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Feb 24, 2026

Uh oh!

arosiclair left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Feb 26, 2026

Uh oh!

dukenv0307 commented Feb 26, 2026

Uh oh!

bernhardoj commented Feb 26, 2026

Uh oh!

bernhardoj commented Feb 27, 2026

Uh oh!

dukenv0307 commented Feb 27, 2026

Uh oh!

dukenv0307 commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Feb 27, 2026

Uh oh!

bernhardoj commented Feb 28, 2026

Uh oh!

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

OSBotify commented Mar 2, 2026

Uh oh!

mitarachim commented Mar 3, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

bernhardoj commented Feb 3, 2026 •

edited

Loading

codecov bot commented Feb 3, 2026 •

edited by github-actions bot

Loading

dukenv0307 commented Feb 4, 2026 •

edited

Loading

dukenv0307 commented Feb 4, 2026 •

edited

Loading

dukenv0307 commented Feb 27, 2026 •

edited

Loading