-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[Onyx audit] Migrate keys to RAM-only - part 1/2 #82309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JKobrynski
wants to merge
28
commits into
Expensify:main
Choose a base branch
from
callstack-internal:JKobrynski/feat/80091-migrate-keys-to-ram-only-part-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+143
−83
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
44aa890
add ramOnlyKeys param to Onyx.init, remove initWithStoredValues
JKobrynski 4436a4f
remove initWithStoredValues: true
JKobrynski 8b95a3a
Merge branch 'main' into JKobrynski/feat/80091-migrate-keys-to-ram-on…
JKobrynski fe16418
add onyx migration for ram-only keys
JKobrynski b58c765
revert accidental Mobile-Expensify submodule pointer change
JKobrynski 6844562
fix canBeMissing for IS_SEARCHING_FOR_REPORTS to true
JKobrynski de91bc0
Merge branch 'main' into JKobrynski/feat/80091-migrate-keys-to-ram-on…
JKobrynski d4c0ac6
fix typo in migration log message
JKobrynski 626d598
address review comments
JKobrynski 93bd301
Merge remote-tracking branch 'origin/main' into JKobrynski/feat/80091…
JKobrynski 4a8d2dc
Merge branch 'main' into JKobrynski/feat/80091-migrate-keys-to-ram-on…
JKobrynski 2ce3734
remove ram-only onyx migration
JKobrynski 97a936f
Merge branch 'main' into JKobrynski/feat/80091-migrate-keys-to-ram-on…
JKobrynski d6f1594
Merge remote-tracking branch 'upstream/main' into JKobrynski/feat/800…
JKobrynski 7370001
remove initWithStoredValues from remaining IS_SEARCHING_FOR_REPORTS
JKobrynski 5666ab1
Merge branch 'main' into JKobrynski/feat/80091-migrate-keys-to-ram-on…
JKobrynski 5f9fcbd
add RAM_ONLY_ prefix to RAM-only keys
JKobrynski e74b1a5
Merge remote-tracking branch 'upstream/main' into JKobrynski/feat/800…
JKobrynski 01634ee
fix failing test, add explanation
JKobrynski bb51ecb
Merge remote-tracking branch 'origin/main' into JKobrynski/feat/80091…
JKobrynski 9bb37d2
fix race condition
JKobrynski c9a31c1
Merge remote-tracking branch 'origin/main' into JKobrynski/feat/80091…
JKobrynski b705408
Merge remote-tracking branch 'origin/main' into JKobrynski/feat/80091…
JKobrynski d2d2d67
apply fix suggested by reviewer
JKobrynski f68144f
handle rejected Linking.getInitialUrl, add timeout
JKobrynski be3f346
add a stale closure guard
JKobrynski 1d287dd
add more documentation to the safety-net
JKobrynski 4e9b00c
Merge remote-tracking branch 'origin/main' into JKobrynski/feat/80091…
JKobrynski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Racing
Linking.getInitialURL()against a 10s null timeout unblocks startup, but it also permanently drops deep links when the native bridge returns the initial URL after that timeout (a case this comment already calls out in HybridApp). Once the timeout wins,onInitialUrl(null)runs and the eventual URL resolution is ignored, so users can land on the default route instead of the intended deep-linked report on slower/lagging startup paths.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Krishna2323 do you have any thoughts on this ☝️ ?