feat: Add inline editing for tables on desktop

[mohammadjafarinejad]

Explanation of Change

Adds inline editing to transaction table cells on desktop for date, merchant, description, category, and amount. Introduces EditableCell, useInlineEditState, and usePopoverEditState as shared primitives for the display/edit toggle pattern.

Fixed Issues

$ #82534
PROPOSAL: #82534 (comment)

Tests

1. Open the app and navigate to the Search/Expenses table on desktop (wide layout)
2. Click a date cell on any transaction row — verify a date picker popover appears anchored to the cell
3. Select a new date — verify the cell updates and the popover closes
4. Click a merchant cell — verify it becomes an inline text input with the current value pre-filled
5. Edit the text and click away (blur) — verify the new value is saved and the cell returns to display mode
6. Repeat steps 4–5 for description and amount cells
7. Click a category cell — verify the category picker popover appears
8. Select a category — verify the cell updates and the popover closes
9. Click a cell on a row where editing is not permitted (e.g. no policy) — verify no edit mode is triggered

• Verify that no errors appear in the JS console

Offline tests

1. Disable network connection
2. Edit a cell value — verify the optimistic update is reflected immediately in the UI
3. Re-enable network — verify the value syncs correctly with the backend

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android-web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

web.mp4

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	93.54% <ø> (ø)
src/components/CategoryPicker/index.tsx	6.25% <ø> (ø)
src/components/MoneyRequestAmountInput.tsx	76.36% <ø> (ø)
src/components/NumberWithSymbolForm.tsx	45.74% <ø> (ø)
...ents/SelectionListWithSections/Search/DateCell.tsx	100.00% <100.00%> (ø)
...ts/SelectionListWithSections/SearchTableHeader.tsx	5.40% <ø> (ø)
...omponents/Table/EditableCell/useInlineEditState.ts	100.00% <100.00%> (ø)
src/components/TagPicker/index.tsx	3.70% <ø> (ø)
...nput/BaseTextInput/implementation/index.native.tsx	78.03% <100.00%> (ø)
...omponents/TransactionItemRow/DataCells/TagCell.tsx	100.00% <100.00%> (ø)
... and 24 more
... and 31 files with indirect coverage changes

[trjExpensify]

@mohammadjafarinejad when do you think this can be opened for review?

[mohammadjafarinejad]

I'm still working on it. I'll try to have it ready within a few hours, or by tomorrow at the latest.

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[melvin-bot]

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

App/src/libs/actions/IOU/index.ts

Lines 5298 to 5299 in 2116cab

	if (isTrackExpenseReport(transactionThreadReport) && isSelfDM(parentReport)) {
	data = getUpdateTrackExpenseParams(transactionID, transactionThreadReport?.reportID, transactionChanges, policy);

Forward hash to track-expense update params for rollback

This branch still calls getUpdateTrackExpenseParams(...) without the new hash argument, even though hash is accepted by the wrapper now to restore snapshot rows on failure; the same omission exists in updateMoneyRequestAmountAndCurrency. For self-DM track-expense edits from Search, a failed date/amount update will keep the optimistic snapshot value instead of reverting, leaving stale data visible until the snapshot is refreshed.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[shawnborton]

Basically I would expect the merchant and description cells to work identically.

[mohammadjafarinejad]

@shawnborton The current TextInput doesn't support this because single-line text scrolls horizontally while multi-line text scrolls vertically. Unlike DescriptionCell, the MerchantCell is a single-line field. I think if we need that behavior, we need to update TextInput, which is out of scope for this PR. @ahmedGaber93 WDYT?

[shawnborton]

Hmm I don't think I am following. Those two cells should behave exactly the same.

[ahmedGaber93]

The current TextInput doesn't support this because single-line text scrolls horizontally while multi-line text scrolls vertically. Unlike DescriptionCell, the MerchantCell is a single-line field. I think if we need that behavior, we need to update TextInput, which is out of scope for this PR.

@mohammadjafarinejad I don't get that, could you please add more details?

I see the both support multi-line on staging

[mohammadjafarinejad]

@shawnborton @ahmedGaber93 Do you mean they should be identical only in preview mode? In edit mode, they cannot be identical because the description is multiline.

[ahmedGaber93]

@mohammadjafarinejad Thanks for the updates.

I am still able to reproduce Issue 1, 3 and 5 here #83127 (comment)

issue 7: pressing enter now do nothing.

video issue 5, 7

20260312205645374.mp4

This issue is back again #83127 (comment)

When I tap outside the field to unfocus the field it selects the expense. This shouldn't happen. It should only unfocus the input, then a second tap would open the expense:

[ahmedGaber93]

Do you mean they should be identical only in preview mode? In edit mode, they cannot be identical because the description is multiline.

Checking in the code ...

[shawnborton]

In edit mode, they cannot be identical because the description is multiline.

That's fine, but in the inline table editing, the controls should be identical IMO. Both of those items - the merchant and description - can grow to two lines in the table cell.

[ahmedGaber93]

The merchant and description can grow to two lines in the table cell.

I think we can support this in preview mode only. In edit mode, allowing the field to grow to multiple lines would also allow users to enter new lines (\n), which is not allowed for the merchant field.

As far as I can see, the current input component in the app doesn’t support a single-line input that can grow in height, so this may require more investigation and might be out of scope for this PR.

@shawnborton Do we have any case in the app where an input is single-line but can grow in height that can we follow it?

[shawnborton]

We are just talking about inline editing here. The inline editing behavior for the merchant and description should be exactly the same.

[ahmedGaber93]

We are just talking about inline editing here. The inline editing behavior for the merchant and description should be exactly the same.

The main challenge is preventing users from entering a new line (\n) with Shift+Enter in the merchant field, since that field doesn’t support new lines. But we can easily allow the inputs to grow in height.

I’ll do a bit more investigation to see how we can allow both inputs to grow in height while only allowing the description field to accept new lines (\n).

[shawnborton]

Yeah, I think I would just remove the new lines after the user exits inline editing mode.

[ahmedGaber93]

Yeah, I think I would just remove the new lines after the user exits inline editing mode.

Great! @mohammadjafarinejad Let’s go with that.

[ahmedGaber93]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dcffdcb273

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[trjExpensify]

How we looking here to get it over the line this week?

[mohammadjafarinejad]

@ahmedGaber93 Ready for re-review.

I cannot reproduce this issue (tapping outside the input selects the expense). Could you please check it again?

Video

issue7_unfocus_bug.mp4

[ahmedGaber93]

Thanks for the update. I’m AFK for now and will review it in a few hours.