Filter Expensify team members from approval workflows table by MobileMage · Pull Request #83366 · Expensify/App

MobileMage · 2026-02-24T19:45:19Z

Explanation of Change

Filters internal Expensify team members (SRAMs/guides with @expensify.com or @team.expensify.com emails) from the approval workflows table in Workspace Workflows. This matches the existing filtering behavior already implemented in WorkspaceMembersPage.

Changes in WorkflowUtils.ts:

Added currentUserLogin param to convertPolicyEmployeesToApprovalWorkflows
When the policy owner and current user are both non-Expensify, Expensify team members are filtered from workflow members, approvers, and available members
If an employee's submitsTo points to an Expensify team member, the workflow redirects to the first non-Expensify approver in the forwardsTo chain
No filtering is applied when the policy owner or current user is an Expensify team member (internal use case)

Updated all three call sites to pass currentUserLogin:

WorkspaceWorkflowsPage.tsx
WorkspaceWorkflowsApprovalsEditPage.tsx
WorkspaceMemberDetailsPage.tsx

Fixed Issues

$ #80744
PROPOSAL: #80744 (comment)

Tests

Create a workspace owned by a non-Expensify email
Add an Expensify team member (e.g., an @expensify.com email) to the workspace
Navigate to Workspace > Workflows
Click "Add Approval Workflow"
Verify the Expensify team member does not appear in the menu

Verify that no errors appear in the JS console

Offline tests

N/A - The filtering logic runs client-side and does not depend on network state.

QA Steps

Create a workspace owned by a non-Expensify email
Add an Expensify team member (e.g., an @expensify.com email) to the workspace
Navigate to Workspace > Workflows
Click "Add Approval Workflow"
Verify the Expensify team member does not appear in the menu

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Kapture.2026-03-09.at.17.56.29.mp4

codecov · 2026-02-24T22:15:36Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...s/workspace/members/WorkspaceMemberDetailsPage.tsx	`0.00% <ø> (ø)`
.../approvals/WorkspaceWorkflowsApprovalsEditPage.tsx	`73.07% <ø> (ø)`
...ges/workspace/workflows/WorkspaceWorkflowsPage.tsx	`0.00% <0.00%> (ø)`
src/libs/WorkflowUtils.ts	`77.11% <48.00%> (-4.31%)`	⬇️
... and 407 files with indirect coverage changes

…ows-table

melvin-bot · 2026-03-09T16:57:35Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eh2077

Looks good overall, can you add unit tests to cover changes please?

eh2077 · 2026-03-10T10:18:41Z

src/libs/WorkflowUtils.ts

+    // Determine if we should filter Expensify team members (only for non-Expensify customers)
+    const shouldFilterExpensifyTeam = !!policyOwner && !!currentUserLogin && !isExpensifyTeam(policyOwner) && !isExpensifyTeam(currentUserLogin);


I think this condition intents to filter out Expensify team members, so please update the comment and rename to variable to shouldFilterOutExpensifyTeam

trjExpensify

Create a workspace owned by a non-Expensify email

Add an Expensify team member (e.g., an @expensify.com email) to the workspace

Configure the Expensify team member as an approver in a workflow

Navigate to Workspace > Workflows

Verify the Expensify team member does not appear in the workflows table (not as a member or approver)

Click "Add Approval Workflow"

Verify the Expensify team member does not appear in the menu

The tests don't make sense. How can you do step 3?

MobileMage · 2026-03-11T23:41:55Z

Right, updated @trjExpensify

eh2077 · 2026-03-12T15:20:36Z

@MobileMage bump on #83366 (review), thanks!

MobileMage · 2026-03-12T15:48:43Z

@eh2077 done

eh2077 · 2026-03-12T15:50:17Z

Can you also add unit tests?

MobileMage · 2026-03-12T17:43:16Z

Added @eh2077

eh2077 · 2026-03-13T13:21:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

eh2077 · 2026-03-13T13:48:25Z

@MobileMage I can still select an Expensify team (fake) member when adding a new workflow

Screen.Recording.2026-03-13.at.9.46.29.PM.mov

MobileMage · 2026-03-13T13:51:10Z

Looking into it now

MobileMage · 2026-03-13T14:49:16Z

@eh2077 that's odd, can't seem to reproduce

Here's how it looks for me, left is staging, right is my branch

Are you sure you've got the right branch?

Filter Expensify team members from approval workflows table

31ee903

melvin-bot bot assigned MobileMage Feb 24, 2026

Merge remote-tracking branch 'origin/main' into fix/80744-sram-workfl…

1c9baa3

…ows-table

MobileMage marked this pull request as ready for review March 9, 2026 16:57

MobileMage requested review from a team as code owners March 9, 2026 16:57

melvin-bot bot requested review from eh2077 and removed request for a team March 9, 2026 16:57

melvin-bot bot requested review from trjExpensify and removed request for a team March 9, 2026 16:57

eh2077 reviewed Mar 10, 2026

View reviewed changes

trjExpensify requested changes Mar 11, 2026

View reviewed changes

Rename shouldFilterExpensifyTeam to shouldFilterOutExpensifyTeam

227f9b1

Add unit tests for Expensify team filtering in workflows

ecea97e

		// Determine if we should filter Expensify team members (only for non-Expensify customers)
		const shouldFilterExpensifyTeam = !!policyOwner && !!currentUserLogin && !isExpensifyTeam(policyOwner) && !isExpensifyTeam(currentUserLogin);

Conversation

MobileMage commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Feb 24, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Mar 9, 2026

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

eh2077 Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

MobileMage commented Mar 11, 2026

Uh oh!

eh2077 commented Mar 12, 2026

Uh oh!

MobileMage commented Mar 12, 2026

Uh oh!

eh2077 commented Mar 12, 2026

Uh oh!

MobileMage commented Mar 12, 2026

Uh oh!

eh2077 commented Mar 13, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 commented Mar 13, 2026

Uh oh!

MobileMage commented Mar 13, 2026

Uh oh!

MobileMage commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MobileMage commented Feb 24, 2026 •

edited

Loading

codecov bot commented Feb 24, 2026 •

edited by github-actions bot

Loading