Added "Create" button on Reports page

[mukhrr]

Explanation of Change

Fixed Issues

$ #83430
PROPOSAL: #83430 (comment)

Tests

the same as QA

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Desktop:

1. Go to Reports
2. Verify there is "Create" button on right top
3. Tro to apply more filters
4. Verify filters don't overlap Create button

Mobile

1. Go to Reports
2. Verify filters are horizontally scrollable

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

[melvin-bot]

@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...nents/Search/SearchPageHeader/SearchFiltersBar.tsx	100.00% <100.00%> (+32.35%)	⬆️
src/selectors/Policy.ts	47.50% <100.00%> (+1.34%)	⬆️
src/styles/index.ts	46.39% <ø> (ø)
...Search/SearchPageHeader/MultiSelectFilterPopup.tsx	0.00% <0.00%> (ø)
...Search/SearchPageHeader/SearchFiltersBarNarrow.tsx	80.00% <80.00%> (ø)
.../Search/SearchPageHeader/DatePickerFilterPopup.tsx	0.00% <0.00%> (ø)
...s/Search/SearchPageHeader/SearchFiltersBarWide.tsx	14.28% <14.28%> (ø)
.../SearchPageHeader/SearchFiltersBarCreateButton.tsx	4.34% <4.34%> (ø)
...ts/Search/SearchPageHeader/useSearchFiltersBar.tsx	71.26% <71.26%> (ø)
... and 194 files with indirect coverage changes

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5055df13ae

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[dubielzyk-expensify]

Could you add screenshots @mukhrr ?

Let me know when I can run an adhoc test, @luacmartins :)

[mukhrr]

@dubielzyk-expensify done

[github-actions]

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

[shawnborton]

I think we only show the Create report option if you have a workspace, right? It seems like right now we just always show it. We probably want to follow the same logic as the global create button.

[shawnborton]

@trjExpensify that being said, why don't we just allow any new account to try to create a report (so always show it in global create and the reports page empty state), and just show the create a workspace modal when they do?

[trjExpensify]

I believe that came back to the "track should be funnelled to off-workspace" using the selfDM instead, and all the business intents created a workspace on sign-up. We're working elsewhere on creating workspaces out the gate for Track intent sign-ups now going forward, so I think we don't need to worry and that will take care of it.

[shawnborton]

Hmm not sure if I agree though. For people that simply choose "Something else" I feel like we're missing an opportunity here for them to easily make reports.

[shawnborton]

Anyways we can discuss that later. In the meantime, I think we need to align the "Create report" behavior with global create. Can you please update @mukhrr ? Thanks!

[trjExpensify]

Anyways we can discuss that later.

Yeah, not super passionate about maintaining what we have long term - especially as we are looking to create workspaces for track out the gate now. Agree it doesn't feel in scope of this PR though.

[dannymcclain]

Are we cool with having this button on Reports > Chats? It feels a little odd, but I'm fine with it because having Chats on Reports already feels odd to me haha.

[joekaufmanexpensify]

Change is good from product perspective

[dubielzyk-expensify]

Are we cool with having this button on Reports > Chats? It feels a little odd, but I'm fine with it because having Chats on Reports already feels odd to me haha.

Yeah I'm fine with it and think the Adhoc mobile and desktop looks pretty good to me 👍

[mukhrr]

@luacmartins @shawnborton Could you pls have a look at this once more and give me feedbacks?! thanks!

[github-actions]

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83541.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c0bb8bd-4b42a14-d3efa7eeb6c72b25d0fafe531784462ead9b023b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c0bb8bd-4b42a14-2841ce9ef665e5df2762087ce8dba26b336deb4c/index.html

Web 🕸️
https://83541.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[shawnborton]

Works great to me, let's get this thing merged! cc @puneetlath @luacmartins

[puneetlath]

Are there any tests we should add?

[dannymcclain]

Design team approved 👍

[mukhrr]

@shawnborton @trjExpensify I think it's okay to implement #83782 right here. What do you think?!