Added "Create" button on Reports page#83541
Conversation
|
@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5055df13ae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Could you add screenshots @mukhrr ? Let me know when I can run an adhoc test, @luacmartins :) |
|
@dubielzyk-expensify done |
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
I think we only show the Create report option if you have a workspace, right? It seems like right now we just always show it. We probably want to follow the same logic as the global create button. |
|
@trjExpensify that being said, why don't we just allow any new account to try to create a report (so always show it in global create and the reports page empty state), and just show the create a workspace modal when they do? |
|
I believe that came back to the "track should be funnelled to off-workspace" using the selfDM instead, and all the business intents created a workspace on sign-up. We're working elsewhere on creating workspaces out the gate for Track intent sign-ups now going forward, so I think we don't need to worry and that will take care of it. |
|
Hmm not sure if I agree though. For people that simply choose "Something else" I feel like we're missing an opportunity here for them to easily make reports. |
|
Anyways we can discuss that later. In the meantime, I think we need to align the "Create report" behavior with global create. Can you please update @mukhrr ? Thanks! |
Yeah, not super passionate about maintaining what we have long term - especially as we are looking to create workspaces for track out the gate now. Agree it doesn't feel in scope of this PR though. |
|
Are we cool with having this button on |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Change is good from product perspective
Yeah I'm fine with it and think the Adhoc mobile and desktop looks pretty good to me 👍 |
|
Fully agree with you, Jason |
|
@puneetlath @luacmartins anything else to review before we get this merged? I notice we don't have C+ on this PR. |
@JmillsExpensify i was thinking about fixing #83782 here. Waiting for @marcaaron response there |
We should definitely get C+ on this. Assigned @eVoloshchak since they're assigned to the issue. |
@mukhrr I'd recommend doing that in a separate PR to keep the scope small |
|
@eVoloshchak can you give us an ETA on being able to conduct your review? |
luacmartins
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments. LGTM
|
@MelvinBot, resolve conflicts and merge main |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-03-02.at.22.06.06.movAndroid: mWeb ChromeScreen.Recording.2026-03-02.at.22.06.23.moviOS: HybridAppScreen.Recording.2026-03-02.at.22.04.12.moviOS: mWeb SafariScreen.Recording.2026-03-02.at.22.04.50.movMacOS: Chrome / SafariScreen.Recording.2026-03-02.at.22.07.17.mov |
Co-authored-by: Eugene Voloshchak <eVoloshchak@users.noreply.github.com> # Conflicts: # src/components/Search/SearchPageHeader/SearchFiltersBar.tsx
|
Merged Conflict summary: Resolution:
|
|
I think that's expected as it replicates mobile. 👍 |
luacmartins
left a comment
There was a problem hiding this comment.
LGTM. @puneetlath all yours
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.28-0 🚀
|
|
Deploy Blocker #83960 was identified to be related to this PR. |
|
Deploy Blocker #83973 was identified to be related to this PR. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.30-0 🚀
|

Explanation of Change
Fixed Issues
$ #83430
PROPOSAL: #83430 (comment)
Tests
the same as QA
Offline tests
QA Steps
Desktop:
Mobile
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4