Skip to content

Duplicate Distance Expenses fixes #84282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jjcoffee wants to merge 4 commits into
base: main
Choose a base branch
from
+8 −3
Draft

Duplicate Distance Expenses fixes #84282

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b2d261
fix: pass required params for odometer expenses
jjcoffee Mar 5, 2026
8ff6d72
fix: duplicating split map distance expense should remain as a manual…
jjcoffee Mar 10, 2026
e85546d
Merge branch 'main' into fix/duplicate-distance-expense-fixes
jjcoffee Mar 12, 2026
675eee3
Merge branch 'main' into fix/duplicate-distance-expense-fixes
jjcoffee Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/libs/actions/IOU/Duplicate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
buildTransactionThread,
getTransactionDetails,
} from '@libs/ReportUtils';
import {getRequestType, getTransactionType, isDistanceRequest, isExpenseSplit} from '@libs/TransactionUtils';
import {getRequestType, getTransactionType, isDistanceRequest, isExpenseSplit, isOdometerDistanceRequest} from '@libs/TransactionUtils';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import type * as OnyxTypes from '@src/types/onyx';
Expand Down Expand Up @@ -564,6 +564,8 @@ function duplicateExpenseTransaction({
merchant: transaction?.modifiedMerchant ? transaction.modifiedMerchant : (transaction?.merchant ?? ''),
modifiedAmount: undefined,
originalTransactionID: undefined,
odometerStart: transaction?.comment?.odometerStart ?? undefined,
odometerEnd: transaction?.comment?.odometerEnd ?? undefined,
receipt: undefined,
source: undefined,
waypoints,
Expand All @@ -587,8 +589,9 @@ function duplicateExpenseTransaction({
personalDetails,
};

// Since we remove waypoints for split distance expenses, we need to re-add the distance param here
if (isExpenseSplit(transaction) && isDistanceRequest(transaction)) {
// We remove waypoints for split distance expenses, so we have to re-add the distance param here.
// Odometer expenses don't have the distance parameter so we also need to pass it here.
if (isDistanceRequest(transaction) && (isExpenseSplit(transaction) || isOdometerDistanceRequest(transaction))) {
params.transactionParams.distance = transaction.comment?.customUnit?.quantity ?? undefined;
}

Expand All @@ -606,6 +609,7 @@ function duplicateExpenseTransaction({
...transaction.comment,
originalTransactionID: undefined,
source: undefined,
waypoints,
},
iouRequestType: getRequestType(transaction),
modifiedCreated: '',
Expand Down Expand Up @@ -648,6 +652,7 @@ function duplicateExpenseTransaction({
...transaction.comment,
originalTransactionID: undefined,
source: undefined,
waypoints,
},
iouRequestType: getRequestType(transaction),
modifiedCreated: '',
Expand Down
Loading