-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[NO QA] Add Propagation of Derived Parameters to Dynamic Routes State #85079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mjasikowski
merged 4 commits into
Expensify:main
from
software-mansion-labs:collectioneur/dynamic-routes-parameters-propagating
Mar 14, 2026
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d926cf7
add parameters propagating to dynamic routes state
collectioneur 7743f77
Merge branch 'main' into collectioneur/dynamic-routes-parameters-prop…
collectioneur 961418f
cleanup
collectioneur 88b4337
ensure that params aren't undefined
collectioneur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ import splitPathAndQuery from './splitPathAndQuery'; | |
| type LeafRoute = { | ||
| name: string; | ||
| path: string; | ||
| params?: Record<string, string>; | ||
| params?: Record<string, unknown>; | ||
| }; | ||
|
|
||
| type NestedRoute = { | ||
|
|
@@ -54,7 +54,7 @@ function getRouteNamesForDynamicRoute(dynamicRouteName: DynamicRouteSuffix): str | |
| return null; | ||
| } | ||
|
|
||
| function getStateForDynamicRoute(path: string, dynamicRouteName: keyof typeof DYNAMIC_ROUTES) { | ||
| function getStateForDynamicRoute(path: string, dynamicRouteName: keyof typeof DYNAMIC_ROUTES, parentRouteParams?: Record<string, unknown>) { | ||
| const routeConfig = getRouteNamesForDynamicRoute(DYNAMIC_ROUTES[dynamicRouteName].path); | ||
| const [, query] = splitPathAndQuery(path); | ||
| const params = getParamsFromQuery(query); | ||
|
|
@@ -67,12 +67,13 @@ function getStateForDynamicRoute(path: string, dynamicRouteName: keyof typeof DY | |
| const buildNestedState = (routes: string[], currentIndex: number): RouteNode => { | ||
| const currentRoute = routes.at(currentIndex); | ||
|
|
||
| // If this is the last route, create leaf node with path | ||
| // If this is the last route, create leaf node with path and merged params | ||
| if (currentIndex === routes.length - 1) { | ||
| const mergedParams = parentRouteParams || params ? {...parentRouteParams, ...params} : undefined; | ||
| return { | ||
| name: currentRoute ?? '', | ||
| path, | ||
| params, | ||
| ...(mergedParams ? {params: mergedParams} : {}), | ||
|
||
| }; | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked this yesterday and noticed that
paramscan possibly beundefined. Spreadingundefinedmay cause a runtime error:TypeError: Cannot convert undefined or null to object.So to make this safer, I would recommend adding a fallback {}.
const mergedParams = parentRouteParams || params ? {...(parentRouteParams ?? {}), ...(params ?? {})} : undefined;