Skip to content

[CP Staging] Revert "Enable platform tree shaking in hermes bundle"#85099

Merged
mountiny merged 1 commit intomainfrom
revert-83359-cleanup-platform-specifics-from-hermes-build
Mar 12, 2026
Merged

[CP Staging] Revert "Enable platform tree shaking in hermes bundle"#85099
mountiny merged 1 commit intomainfrom
revert-83359-cleanup-platform-specifics-from-hermes-build

Conversation

@luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Mar 12, 2026 •
edited
Loading

Fixed issue

$ #84969
$ #85018

QA steps

Same as fixed issues

Reverts #83359

@luacmartins luacmartins self-assigned this Mar 12, 2026
@luacmartins luacmartins mentioned this pull request Mar 12, 2026
Merged
50 tasks
@luacmartins luacmartins marked this pull request as ready for review March 12, 2026 15:22
@luacmartins luacmartins requested a review from a team as a code owner March 12, 2026 15:22
@melvin-bot melvin-bot bot requested a review from mollfpr March 12, 2026 15:23
@melvin-bot
Copy link

melvin-bot bot commented Mar 12, 2026

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team March 12, 2026 15:23
@luacmartins luacmartins changed the title Revert "Enable platform tree shaking in hermes bundle" [CP Staging] Revert "Enable platform tree shaking in hermes bundle" Mar 12, 2026
@mountiny mountiny merged commit 2c0a2cb into main Mar 12, 2026
39 of 45 checks passed
@mountiny mountiny deleted the revert-83359-cleanup-platform-specifics-from-hermes-build branch March 12, 2026 15:26
@melvin-bot melvin-bot bot added the Emergency label Mar 12, 2026
@mountiny
Copy link
Contributor

mountiny commented Mar 12, 2026

Not emergency, straight revert

@melvin-bot
Copy link

melvin-bot bot commented Mar 12, 2026

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

Sign in to view
@OSBotify
Copy link
Contributor

OSBotify commented Mar 12, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment was marked as outdated.

Sign in to view
@Julesssss
Copy link
Contributor

Julesssss commented Mar 12, 2026

Can't build currently, 1pass is down

OSBotify pushed a commit that referenced this pull request Mar 12, 2026
@mountiny @OSBotify
Merge pull request #85099 from Expensify/revert-83359-cleanup-platfor…
0527479 
…m-specifics-from-hermes-build

[CP Staging] Revert "Enable platform tree shaking in hermes bundle"

(cherry picked from commit 2c0a2cb)

(cherry-picked to staging by luacmartins)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Mar 12, 2026
@OSBotify OSBotify mentioned this pull request Mar 12, 2026
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 12, 2026

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.36-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85099.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-acadc0e-fda79d3-c5a61c9e34c7159e233bbaf3fdc066fd347507e3/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-acadc0e-fda79d3-183a6d3a16b3ac0bcb4c000e6d76ad130e1d3544/index.html
Android iOS
Web 🕸️
https://85099.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@Julesssss
Copy link
Contributor

Julesssss commented Mar 12, 2026

Requesting retest

@OSBotify
Copy link
Contributor

OSBotify commented Mar 12, 2026

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.36-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 12, 2026

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 12, 2026

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.37-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

@mountiny mountiny mountiny approved these changes

@mollfpr mollfpr Awaiting requested review from mollfpr

Assignees

@luacmartins luacmartins

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@luacmartins @mountiny @OSBotify @Julesssss @NikkiWines