Skip to content

Add accessibilityLabel to picker dismiss button for VoiceOver #85103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MelvinBot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add accessibilityLabel to picker dismiss button for VoiceOver #85103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
930a49c
Add accessibilityLabel to picker dismiss button
MelvinBot Mar 12, 2026
ebbc54d
Fix: sort imports alphabetically to pass Prettier check
MelvinBot Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/Picker/BasePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import FormHelpMessage from '@components/FormHelpMessage';
import Icon from '@components/Icon';
import Text from '@components/Text';
import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset';
import useLocalize from '@hooks/useLocalize';
import useScrollContext from '@hooks/useScrollContext';
import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
Expand Down Expand Up @@ -42,6 +43,7 @@ function BasePicker<TPickerValue>({
ref,
}: BasePickerProps<TPickerValue>) {
const icons = useMemoizedLazyExpensifyIcons(['DownArrow']);
const {translate} = useLocalize();
const theme = useTheme();
const styles = useThemeStyles();

Expand Down Expand Up @@ -213,6 +215,7 @@ function BasePicker<TPickerValue>({
}}
touchableDoneProps={{
accessibilityRole: CONST.ROLE.BUTTON,
accessibilityLabel: translate('common.dismiss'),
}}
touchableWrapperProps={{
accessible: true,
Expand Down
Loading