-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix content alignment & improvemance #85306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 6 commits
6b2ebd6
881bd22
495d176
bb06be6
aaf5bcc
e6e8657
0628684
c1acd81
573213a
3305b14
b7316a8
3bc0fc3
23ef347
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| import mapValues from 'lodash/mapValues'; | ||
| import React, {memo, use, useCallback, useContext, useEffect, useMemo, useRef, useState} from 'react'; | ||
| import type {GestureResponderEvent, TextInput} from 'react-native'; | ||
| import {InteractionManager, Keyboard, Platform, View} from 'react-native'; | ||
| import {InteractionManager, Keyboard, View} from 'react-native'; | ||
| import type {OnyxCollection, OnyxEntry} from 'react-native-onyx'; | ||
| import type {ValueOf} from 'type-fest'; | ||
| import type {Emoji} from '@assets/emojis/types'; | ||
|
|
@@ -67,6 +67,7 @@ | |
| import {getLatestErrorMessageField, isReceiptError} from '@libs/ErrorUtils'; | ||
| import focusComposerWithDelay from '@libs/focusComposerWithDelay'; | ||
| import getNonEmptyStringOnyxID from '@libs/getNonEmptyStringOnyxID'; | ||
| import getPlatform from '@libs/getPlatform'; | ||
| import {isReportMessageAttachment} from '@libs/isReportMessageAttachment'; | ||
| import Navigation from '@libs/Navigation/Navigation'; | ||
| import {getBankAccountLastFourDigits} from '@libs/PaymentUtils'; | ||
|
|
@@ -546,6 +547,8 @@ | |
| const {transitionActionSheetState} = ActionSheetAwareScrollView.useActionSheetAwareScrollViewActions(); | ||
| const {translate, formatPhoneNumber, localeCompare, formatTravelDate, getLocalDateFromDatetime, datetimeToCalendarTime} = useLocalize(); | ||
| const {showConfirmModal} = useConfirmModal(); | ||
| const platform = getPlatform(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❌ CONSISTENCY-1 (docs)The PR introduces If keeping the platform check inline, prefer the original accessibilityRole={Platform.OS !== CONST.PLATFORM.WEB ? CONST.ROLE.BUTTON : undefined}Alternatively, extract the platform-specific Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency. |
||
| const isWeb = platform === CONST.PLATFORM.WEB; | ||
| const personalDetail = useCurrentUserPersonalDetails(); | ||
| const {shouldUseNarrowLayout} = useResponsiveLayout(); | ||
| const reportID = report?.reportID ?? action?.reportID; | ||
|
|
@@ -623,7 +626,7 @@ | |
| clearError(transactionID); | ||
| } | ||
| clearAllRelatedReportActionErrors(reportID, action, originalReportID); | ||
| }, [action, isSendingMoney, reportID, clearAllRelatedReportActionErrors, report, chatReport, clearError]); | ||
|
|
||
| const showDismissReceiptErrorModal = useCallback(async () => { | ||
| const result = await showConfirmModal({ | ||
|
|
@@ -2056,7 +2059,7 @@ | |
| withoutFocusOnSecondaryInteraction | ||
| accessibilityLabel={accessibilityLabel} | ||
| accessibilityHint={translate('accessibilityHints.chatMessage')} | ||
| accessibilityRole={Platform.OS !== CONST.PLATFORM.WEB ? CONST.ROLE.BUTTON : undefined} | ||
| accessibilityRole={!isWeb ? CONST.ROLE.BUTTON : undefined} | ||
| sentryLabel={CONST.SENTRY_LABEL.REPORT.PURE_REPORT_ACTION_ITEM} | ||
| > | ||
| <Hoverable | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.