Fix 'Not here' page when creating workspace for client with makeMeAdmin off by allgandalf · Pull Request #86331 · Expensify/App

allgandalf · 2026-03-25T16:12:02Z

Explanation of Change

When an approved accountant creates a workspace for a client with "Keep me as admin" toggled off, the app navigates to the workspace page where the user sees a "Not here" page because the backend never adds them as a member.

This PR fixes this by:

Showing a success confirmation page instead of navigating to the workspace when makeMeAdmin=false and the owner is a different user. This matches OldDot behavior where the accountant gets a success message and does NOT navigate to the workspace.
Fixing optimistic employeeList in buildPolicyData to not add the caller when makeMeAdmin=false, since the backend never adds them — the optimistic data now matches server behavior.

Fixed Issues

$ #83995

Tests

Set your account as an approved accountant (requires backend access or ngrok)
Go to Workspaces > New workspace
Select another account as Owner
Toggle OFF "Keep me as an admin"
Submit the workspace creation form
Verify a success confirmation page appears with the heading "You've created a workspace for your client!" and a "Got it" button
Tap "Got it"
Verify you are taken back to the Workspaces list (NOT to the workspace page)
Repeat steps 2-5 but with "Keep me as an admin" toggled ON
Verify you are navigated to the workspace page as normal

Verify that no errors appear in the JS console

Offline tests

Create a workspace for a client with "Keep me as admin" OFF while online
Verify the success page appears
Toggle airplane mode ON before tapping "Got it"
Tap "Got it" — verify you return to the Workspaces list without errors

QA Steps

Log in as an approved accountant (use ngrok or local backend)
Create a new workspace, select a different owner, toggle OFF "Keep me as an admin"
Verify a confirmation page appears saying "You've created a workspace for your client!"
Tap "Got it" and verify you return to the Workspaces list
Verify the workspace was created and the accountant is NOT a member of it
Repeat with "Keep me as an admin" ON — verify normal workspace navigation

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2026-03-26.at.10.57.24.AM.mov

Backend never adds the caller when they opt out of admin, so the optimistic data should match.

When creating a workspace for a client without keeping admin role, navigate to a confirmation page instead of the workspace page that the user won't have access to.

melvin-bot · 2026-03-25T16:12:09Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-03-25T16:12:10Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2026-03-25T16:12:53Z

@JmillsExpensify please hold on review, the C+ still needs to test the issue with my local dev setu

allgandalf · 2026-03-25T16:14:49Z

@QichenZhu , For you to connect and test this correctly, lets test this in my VM, i am available between:

01:30–06:30 UTC
08:30–11:30 UTC
13:30–15:30 UTC

Does any of the above time work with you ? if not i can probably keep my VM active and then you can test according to your time. let me know

codecov · 2026-03-25T16:22:49Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/ROUTES.ts	`15.70% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
src/libs/actions/Policy/Policy.ts	`65.11% <100.00%> (-0.21%)`	⬇️
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.92% <0.00%> (-0.01%)`	⬇️
src/pages/workspace/WorkspaceConfirmationPage.tsx	`0.00% <0.00%> (ø)`
...ges/workspace/WorkspaceConfirmationSuccessPage.tsx	`0.00% <0.00%> (ø)`
... and 11 files with indirect coverage changes

QichenZhu · 2026-03-26T02:54:54Z

Does any of the above time work with you ?

@allgandalf 01:30–06:30 UTC and 08:30–11:30 UTC work for me.

allgandalf · 2026-03-26T04:59:53Z

Talking with @QichenZhu 1:1 https://expensify.slack.com/archives/D0911DCEKGQ/p1774500047311449

…on-for-client

…mber When makeMeAdmin=false and the owner is different, the backend never adds the caller to the workspace. The optimistic policy data should not set role=ADMIN, otherwise the workspace briefly appears in the accountant's list before being removed on server response.

allgandalf · 2026-03-26T06:59:16Z

src/languages/es.ts

+        createdForClient: {
+            title: '¡Has creado un espacio de trabajo para tu cliente!',
+            description: 'Excelentes noticias 🎉. Contáctanos si necesitan ayuda con la configuración.',


confirming here https://expensify.slack.com/archives/C01GTK53T8Q/p1774501599739639

QichenZhu · 2026-03-26T07:21:11Z

An edge case: do we need a fail page when creating a workspace for a non-existent user?

Screen.Recording.2026-03-26.at.8.12.39.PM.mov

QichenZhu · 2026-03-26T07:40:16Z

NAB: #admins room shows in LHN even when the current user is not the admin or owner. This also happens on main.

Screen.Recording.2026-03-26.at.8.38.00.PM.mov

src/pages/workspace/WorkspaceConfirmationSuccessPage.tsx

allgandalf · 2026-03-27T08:14:32Z

good point! i think we should handle that — the backend returns a 404 when the owner email doesnt have a proper account. i'll add an error state for that. or alternatively, we could just show the generic error on the workspace page (which already happens via onyxData in the 404 response). wdyt?

…on-for-client

QichenZhu · 2026-03-27T10:08:38Z

cc @trjExpensify @blimpich for the question above about how to show the error.

trjExpensify · 2026-03-27T17:11:10Z

Mhm.. did you test this on Expensify Classic? I'm not aware of the restriction on existing accounts only.

JmillsExpensify

LGTM

trjExpensify · 2026-03-30T11:12:14Z

Mhm.. did you test this on Expensify Classic? I'm not aware of the restriction on existing accounts only.

@QichenZhu @allgandalf were you able to test this on Classic?

QichenZhu · 2026-03-30T11:16:38Z

I'm not able to test it. I don't have an approved accountant account, and I don't know how to test OldDot using the ngrok server.

allgandalf · 2026-03-30T11:17:38Z

Mhm.. did you test this on Expensify Classic? I'm not aware of the restriction on existing accounts only.

@QichenZhu @allgandalf were you able to test this on Classic?

Just started my day, will check

allgandalf · 2026-03-31T06:48:31Z

I'm not able to test it. I don't have an approved accountant account, and I don't know how to test OldDot using the ngrok server.

Okay i tested on OD and it doesn't block, @QichenZhu i also tested on my branch locally and it works, i think there must be some issue when you tested, you can continue with checklist i think and test again , please DM me on slack when you want to test again, thanks !

…on-for-client

QichenZhu · 2026-03-31T07:26:36Z

@allgandalf CreateWorkspace still returned an error, and the workspace was not created. Am I missing something?

Screen.Recording.2026-03-31.at.8.23.32.PM.mov

QichenZhu · 2026-03-31T07:30:07Z

Also, what do you think about #86331 (comment)? I think it doesn't block this PR, but blocks the original issue.

…on-for-client

allgandalf added 5 commits March 25, 2026 21:40

Add navigation config for workspace confirmation success page

8a149a6

Add translation strings for workspace created for client page

c2f441f

Add WorkspaceConfirmationSuccessPage component

ae0eb4d

Don't add caller to optimistic employeeList when makeMeAdmin is false

6615eae

Backend never adds the caller when they opt out of admin, so the optimistic data should match.

Navigate to success page instead of workspace when makeMeAdmin is off

79a6a72

When creating a workspace for a client without keeping admin role, navigate to a confirmation page instead of the workspace page that the user won't have access to.

allgandalf requested review from a team as code owners March 25, 2026 16:12

melvin-bot bot assigned allgandalf Mar 25, 2026

melvin-bot bot requested a review from QichenZhu March 25, 2026 16:12

melvin-bot bot requested review from JmillsExpensify and removed request for a team March 25, 2026 16:12

melvin-bot bot removed the request for review from a team March 25, 2026 16:12

allgandalf added 3 commits March 26, 2026 10:31

Merge branch 'Expensify:main' into fix-not-here-page-workspace-creati…

5bace2a

…on-for-client

Translate createdForClient strings into all supported languages

b07e9d5

allgandalf commented Mar 26, 2026

View reviewed changes

QichenZhu suggested changes Mar 26, 2026

View reviewed changes

src/pages/workspace/WorkspaceConfirmationSuccessPage.tsx Outdated Show resolved Hide resolved

allgandalf added 2 commits March 27, 2026 13:48

Use confirmWorkspace translation key for header title

f1f66a2

Merge branch 'Expensify:main' into fix-not-here-page-workspace-creati…

7fae588

…on-for-client

JmillsExpensify reviewed Mar 29, 2026

View reviewed changes

trjExpensify mentioned this pull request Mar 30, 2026

[CFI] Approved! - Add the ability to create a workspace for a client. #80057

Open

7 tasks

Merge branch 'Expensify:main' into fix-not-here-page-workspace-creati…

ae7bb6d

…on-for-client

Merge branch 'Expensify:main' into fix-not-here-page-workspace-creati…

8c40145

…on-for-client

Conversation

allgandalf commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 25, 2026

Uh oh!

melvin-bot bot commented Mar 25, 2026

Uh oh!

allgandalf commented Mar 25, 2026

Uh oh!

allgandalf commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 25, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

QichenZhu commented Mar 26, 2026

Uh oh!

allgandalf commented Mar 26, 2026

Uh oh!

allgandalf Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

QichenZhu commented Mar 26, 2026

Uh oh!

QichenZhu commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

allgandalf commented Mar 27, 2026

Uh oh!

QichenZhu commented Mar 27, 2026

Uh oh!

trjExpensify commented Mar 27, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented Mar 30, 2026

Uh oh!

QichenZhu commented Mar 30, 2026

Uh oh!

allgandalf commented Mar 30, 2026

Uh oh!

allgandalf commented Mar 31, 2026

Uh oh!

QichenZhu commented Mar 31, 2026

Uh oh!

QichenZhu commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

allgandalf commented Mar 25, 2026 •

edited

Loading

allgandalf commented Mar 25, 2026 •

edited

Loading

codecov bot commented Mar 25, 2026 •

edited by github-actions bot

Loading

QichenZhu commented Mar 26, 2026 •

edited

Loading