[No QA] Update business bank account help articles#86599
[No QA] Update business bank account help articles#86599
Conversation
…ompliance Revises all 5 business bank account help articles to follow HelpDot authoring guidelines: task-based headings, single # title structure, internalScope metadata, correct three dots formatting, relative cross-links, and HTML comment screenshot placeholders. Adds new content for Wallet entry point, linking existing accounts, and bank account status badges. Co-authored-by: Stephanie Elliott <[email protected]>
docs/articles/new-expensify/wallet-and-payments/Connect-a-Business-Bank-Account.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephanie Elliott <[email protected]>
|
Fixed the failing spellcheck: two typos in |
Co-authored-by: Stephanie Elliott <[email protected]>
|
Fixed the failing spellcheck: corrected two typos in |
HelpDot Documentation ReviewOverall AssessmentThis PR rewrites five business bank account articles (Connect, Share, Unshare, Unlock, Validate) to align with current HelpDot governance standards. The changes are substantial and move these articles significantly closer to compliance: legacy Scores Summary
Key FindingsPositive aspects:
Items to address:
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
docs/articles/new-expensify/wallet-and-payments/Connect-a-Business-Bank-Account.md
Show resolved
Hide resolved
docs/articles/new-expensify/wallet-and-payments/Share-a-Business-Bank-Account.md
Show resolved
Hide resolved
docs/articles/new-expensify/wallet-and-payments/Unlock-a-Business-Bank-Account.md
Show resolved
Hide resolved
docs/articles/new-expensify/wallet-and-payments/Unshare-a-Business-Bank-Account.md
Show resolved
Hide resolved
docs/articles/new-expensify/wallet-and-payments/Validate-a-Business-Bank-Account.md
Show resolved
Hide resolved
docs/articles/new-expensify/wallet-and-payments/Unshare-a-Business-Bank-Account.md
Show resolved
Hide resolved
docs/articles/new-expensify/wallet-and-payments/Unshare-a-Business-Bank-Account.md
Show resolved
Hide resolved
docs/articles/new-expensify/wallet-and-payments/Share-a-Business-Bank-Account.md
Show resolved
Hide resolved
|
@MelvinBot why did you leave comments, instead of in-line suggestions which can be committed? |
|
The review comments with formatting feedback (missing commas, broken horizontal rules, etc.) were posted by That said, I can fix all of those issues right now if you'd like — just reply with |
|
Addressed all bot comments! |
|
@MelvinBot the changes in this PR extend beyond the scoped requirements outlined here. To help reduce the review burden on the assigned project leads, can you provide a structured summary that maps each change in this PR to the corresponding project requirement? Ideally, this should: The goal is to give reviewers a focused checklist, so they don’t need to review all 5 files end-to-end. |
PR Change Mapping to Project RequirementsBelow maps every change in this PR against the scoped requirements (which references the Phase 1–6 design). Legend
1. Connect-a-Business-Bank-Account.md
2. Validate-a-Business-Bank-Account.md
3. Unlock-a-Business-Bank-Account.md
4. Share-a-Business-Bank-Account.md
5. Unshare-a-Business-Bank-Account.md
Reviewer ChecklistPhase 3 (Link existing bank account): Verify Phase 4 (Wallet entry point): Verify all 5 articles now reference "Account > Wallet" navigation and that the new "How to add a new US business bank account in Wallet" section in Phase 5 (Partially set-up accounts): Verify Phase 6 (Locked accounts): Verify Out-of-scope items requiring sign-off:
|
@garrettmknight lot of updates were made on this PR - some were required for this project, some were to de-duplicate content and tighten article scopes, fix outdated instructions, or optimize for AI.
I had Melvin generate a summary that maps the changes in this PR against the project's scoped requirements here, which will hopefully make review a little easier!
Summary
Updates all 5 business bank account help articles to comply with HelpDot authoring guidelines (HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, TEMPLATE.md) and adds new content for Phases 3-5 of the business bank account conversion project.
Articles updated:
Key formatting changes across all articles:
#heading (article title) + optional# FAQ##headings start with a question word (How, What, Where, Who, Why, When)internalScopeto all metadata blocksthe three dots **(⋮)**(per naming conventions)Related to: https://github.com/Expensify/Expensify/issues/530547
Co-authored-by: stephanieelliott [email protected]
Test plan