refactor: `IOURequestStepScan` clean-up, phase 6: move multi-scan state to hook and use `key` for reset by samranahm · Pull Request #86800 · Expensify/App

samranahm · 2026-03-31T22:10:10Z

Explanation of Change

Fixed Issues

$ #79929
PROPOSAL:

Tests

Test 01

Open workspace expense chat and click Create expense.
Go to the Scan tab.
Switch between tabs.
On mobile: enable Multi-scan and capture some receipts.
Disable the Multi-scan or switch to manual tab and verify all receipts get removed.
On desktop web: upload multiple receipt files.
Click Next.
Verify draft transactions are created on the confirmation step.
Click Create expenses.
Verify all expenses are created successfully and appear in the workspace expense chat.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.Native.mp4

Android: mWeb Chrome

Android.mWeb.Chrome.mp4

iOS: Native

IOS.Native.mp4

iOS: mWeb Safari

IOS.mWeb.Safari.mp4

MacOS: Chrome / Safari

macOS.Chrome.mp4

… hook

melvin-bot · 2026-03-31T22:10:27Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copilot

Pull request overview

Refactors the money request Scan step (IOURequestStepScan) to reduce prop-driven state by moving multi-scan/scan-mode state into useReceiptScan, and resets Scan step state via a React key from the start page.

Changes:

Move isMultiScanEnabled and isStartingScan state/derivation into useReceiptScan and remove the related props from Scan step components.
Update web + native Scan step implementations and shared types to match the new hook-driven API.
Update unit/UI tests to interact with the new internal multi-scan state (via hook setters) and remove now-deleted props.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/unit/hooks/useReceiptScan.test.ts	Updates tests to toggle multi-scan via the hook’s setter instead of rerendering with props; adjusts “starting scan” semantics.
tests/ui/IOURequestStepScanTest.tsx	Removes multi-scan props and adds an additional draft transaction to cover multi-draft scenarios.
src/pages/iou/request/step/IOURequestStepScan/types.ts	Removes multi-scan/starting-scan from `UseReceiptScanParams`; makes `isStartingScan` and `setIsMultiScanEnabled` required for mobile hook usage.
src/pages/iou/request/step/IOURequestStepScan/index.tsx	Web Scan step now consumes `isMultiScanEnabled/setIsMultiScanEnabled/isStartingScan` from `useReceiptScan` and passes them down.
src/pages/iou/request/step/IOURequestStepScan/index.native.tsx	Native Scan step now consumes multi-scan + starting-scan state from `useReceiptScan` and wires it into `useMobileReceiptScan`.
src/pages/iou/request/step/IOURequestStepScan/hooks/useReceiptScan.ts	Introduces internal multi-scan state + derives `isStartingScan` from `action`; returns these values to callers.
src/pages/iou/request/step/IOURequestStepScan/hooks/useMobileReceiptScan.ts	Makes `isStartingScan` required and `setIsMultiScanEnabled` non-optional; removes optional chaining on setter usage.
src/pages/iou/request/step/IOURequestStepScan/components/MobileWebCameraView.tsx	Tightens prop types to require `isStartingScan` and `setIsMultiScanEnabled`; keeps `isMultiScanEnabled` defaulting behavior.
src/pages/iou/request/IOURequestStartPage.tsx	Removes parent-held multi-scan state and adds a `key` on `IOURequestStepScan` intended to reset Scan state.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/pages/iou/request/step/IOURequestStepScan/hooks/useReceiptScan.ts

src/pages/iou/request/IOURequestStartPage.tsx

codecov · 2026-03-31T22:53:11Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/pages/iou/request/IOURequestStartPage.tsx	`70.99% <ø> (-0.44%)`	⬇️
...p/IOURequestStepScan/hooks/useMobileReceiptScan.ts	`100.00% <100.00%> (ø)`
...st/step/IOURequestStepScan/hooks/useReceiptScan.ts	`91.17% <100.00%> (-1.14%)`	⬇️
...u/request/step/IOURequestStepScan/index.native.tsx	`40.85% <ø> (-0.08%)`	⬇️
...RequestStepScan/components/MobileWebCameraView.tsx	`0.00% <0.00%> (ø)`
...ages/iou/request/step/IOURequestStepScan/index.tsx	`0.00% <0.00%> (ø)`
... and 359 files with indirect coverage changes

joekaufmanexpensify · 2026-04-01T19:48:51Z

No product review needed

src/pages/iou/request/step/IOURequestStepScan/components/MobileWebCameraView.tsx

bernhardoj · 2026-04-02T15:51:12Z

Please apply this suggestion

src/pages/iou/request/step/IOURequestStepScan/hooks/useReceiptScan.ts

samranahm · 2026-04-02T17:29:45Z

Move isMultiScanEnabled state into useReceiptScan hook (was in parent)

Remove the useEffect that reactively clears receiptFiles on prop change

Clear receiptFiles directly in toggleMultiScan when disabling

Add key={transactionRequestType} on to reset all state on tab switch

Remove isMultiScanEnabled/setIsMultiScanEnabled props from component and type interfaces

Implemented the checklist from #82130 (comment)

samranahm · 2026-04-02T23:50:05Z

@bernhardoj PR ready for re-review.

tests/unit/hooks/useReceiptScan.test.ts

tests/ui/IOURequestStepScanTest.tsx

samranahm · 2026-04-03T14:00:11Z

All checks passing, @bernhardoj please take a look.

src/pages/iou/request/step/IOURequestStepScan/components/MobileWebCameraView.tsx

tests/ui/IOURequestStepScanTest.tsx

bernhardoj · 2026-04-04T02:49:54Z

@codex review

bernhardoj · 2026-04-04T02:54:42Z

@samranahm we are changing the multi-scan code here, so please add test steps for toggling the multi scan or when switching tabs (the other test steps seem unnecessary). Please add recording too.

bernhardoj · 2026-04-04T02:56:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: HybridApp

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

chatgpt-codex-connector · 2026-04-04T03:13:37Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Failed to set up container

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ering Co-authored-by: Bernhard Owen Josephus <[email protected]>

…pScan-phase-6

samranahm · 2026-04-04T11:33:46Z

@bernhardoj All yours.

src/pages/iou/request/step/IOURequestStepScan/components/MobileWebCameraView.tsx

samranahm · 2026-04-04T13:44:26Z

All good, Thanks @bernhardoj for continuous support throughout the project.

samranahm added 3 commits April 1, 2026 02:35

Refactor IOURequestStepScan to own multi-scan state in useReceiptScan…

12b8750

… hook

Remove scan prop and reset scan tab via key remount in RequestStartPage

d6e1b9f

Update IOURequestStepScan tests for hook-owned multi-scan behavior

3e3cb98

Copilot AI review requested due to automatic review settings March 31, 2026 22:10

samranahm requested review from a team as code owners March 31, 2026 22:10

melvin-bot bot requested a review from bernhardoj March 31, 2026 22:10

melvin-bot bot assigned samranahm Mar 31, 2026

melvin-bot bot requested a review from joekaufmanexpensify March 31, 2026 22:10

Copilot started reviewing on behalf of samranahm March 31, 2026 22:10 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

src/pages/iou/request/step/IOURequestStepScan/hooks/useReceiptScan.ts Show resolved Hide resolved

src/pages/iou/request/IOURequestStartPage.tsx Outdated Show resolved Hide resolved

samranahm added 2 commits April 1, 2026 03:42

Improve multi-scan state management in useReceiptScan

d3f7a87

lint

598b3e3

samranahm mentioned this pull request Mar 31, 2026

[$1000] Clean up IOURequestStepScan #79929

Open

joekaufmanexpensify removed their request for review April 1, 2026 19:48

bernhardoj reviewed Apr 2, 2026

View reviewed changes

src/pages/iou/request/step/IOURequestStepScan/components/MobileWebCameraView.tsx Show resolved Hide resolved

bernhardoj reviewed Apr 2, 2026

View reviewed changes

src/pages/iou/request/step/IOURequestStepScan/hooks/useReceiptScan.ts Outdated Show resolved Hide resolved

Refactor isMultiScanEnabled to use useState(false)

45580b7

samranahm added 3 commits April 2, 2026 22:33

Add setReceiptFiles callback to clear receipt files and remove useEffect

6985a3f

Add toggleMultiScan tests for receiptFiles reset

0eaa2c5

update test case

a7ef968

bernhardoj reviewed Apr 3, 2026

View reviewed changes

tests/unit/hooks/useReceiptScan.test.ts Outdated Show resolved Hide resolved

bernhardoj reviewed Apr 3, 2026

View reviewed changes

tests/ui/IOURequestStepScanTest.tsx Outdated Show resolved Hide resolved

refactor receipt handling and update tests for multi-scan functionality

f7c85d6

bernhardoj reviewed Apr 4, 2026

View reviewed changes

src/pages/iou/request/step/IOURequestStepScan/components/MobileWebCameraView.tsx Outdated Show resolved Hide resolved

bernhardoj reviewed Apr 4, 2026

View reviewed changes

tests/ui/IOURequestStepScanTest.tsx Show resolved Hide resolved

samranahm and others added 3 commits April 4, 2026 03:19

refactor IOURequestStepScan test to move transaction merge after rend…

ad40ff3

…ering Co-authored-by: Bernhard Owen Josephus <[email protected]>

fix failing checks

127b410

Merge remote-tracking branch 'upstream/main' into 79929/IOURequestSte…

a013858

…pScan-phase-6

bernhardoj reviewed Apr 4, 2026

View reviewed changes

src/pages/iou/request/step/IOURequestStepScan/components/MobileWebCameraView.tsx Outdated Show resolved Hide resolved

bernhardoj approved these changes Apr 4, 2026

View reviewed changes

melvin-bot bot requested a review from roryabraham April 4, 2026 13:21

change params position

58def4f

Conversation

samranahm commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 31, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joekaufmanexpensify commented Apr 1, 2026

Uh oh!

Uh oh!

bernhardoj commented Apr 2, 2026

Uh oh!

Uh oh!

samranahm commented Apr 2, 2026

Uh oh!

samranahm commented Apr 2, 2026

Uh oh!

Uh oh!

Uh oh!

samranahm commented Apr 3, 2026

Uh oh!

Uh oh!

Uh oh!

bernhardoj commented Apr 4, 2026

Uh oh!

bernhardoj commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernhardoj commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector bot commented Apr 4, 2026

Uh oh!

samranahm commented Apr 4, 2026

Uh oh!

Uh oh!

samranahm commented Apr 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

samranahm commented Mar 31, 2026 •

edited

Loading

codecov bot commented Mar 31, 2026 •

edited by github-actions bot

Loading

bernhardoj commented Apr 4, 2026 •

edited

Loading

bernhardoj commented Apr 4, 2026 •

edited

Loading