fix: prevent Concierge redirect and LHN disappearance when vacation delegate splits expense

src/hooks/useSidebarOrderedReports.tsx

@@ -85,6 +85,23 @@ function SidebarOrderedReportsContextProvider({
     const derivedCurrentReportID = currentReportIDForTests ?? currentReportIDValue;
     const prevDerivedCurrentReportID = usePrevious(derivedCurrentReportID);
 
+    // Track whether the currently-open report is an own workspace chat. We use a ref set
+    // synchronously during render because chatReports[currentReportID] gets wiped to undefined
+    // when a delegate splits an expense — the live value can't be trusted at effect time.
+    // The ref persists through the wipe so the LHN force-inclusion still fires. See issue #84248.
+    const isCurrentReportOwnWorkspaceChatRef = useRef(false);
+    const prevCurrentReportIDForRef = useRef<string | undefined>(undefined);
+    if (derivedCurrentReportID !== prevCurrentReportIDForRef.current) {
+        // Report changed — reset
+        isCurrentReportOwnWorkspaceChatRef.current = false;
+        prevCurrentReportIDForRef.current = derivedCurrentReportID;
+    }
+    const currentChatReportEntry = derivedCurrentReportID ? chatReports?.[`${ONYXKEYS.COLLECTION.REPORT}${derivedCurrentReportID}`] : undefined;
+    if (currentChatReportEntry?.reportID) {
+        isCurrentReportOwnWorkspaceChatRef.current = !!currentChatReportEntry.isOwnPolicyExpenseChat;
+    }
+    // else: report was wiped — intentionally keep the last known value in the ref
+
     // we need to force reportsToDisplayInLHN to re-compute when we clear currentReportsToDisplay, but the way it currently works relies on not having currentReportsToDisplay as a memo dependency, so we just need something we can change to trigger it
     // I don't like it either, but clearing the cache is only a hack for the debug modal and I will endeavor to make it better as I work to improve the cache correctness of the LHN more broadly
     const [clearCacheDummyCounter, setClearCacheDummyCounter] = useState(0);
@@ -284,12 +301,13 @@ function SidebarOrderedReportsContextProvider({
         // the current report is missing from the list, which should very rarely happen. In this
         // case we re-generate the list a 2nd time with the current report included.
 
-        // We also execute the following logic if `shouldUseNarrowLayout` is false because this is
-        // requirement for web. Consider a case, where we have report with expenses and we click on
-        // any expense, a new LHN item is added in the list and is visible on web. But on mobile, we
-        // just navigate to the screen with expense details, so there seems no point to execute this logic on mobile.
+        // On narrow layouts (iOS/mobile) the force-inclusion block is normally skipped because
+        // navigating to a new report simply replaces the screen. However, when a vacation delegate
+        // splits an expense, a temporary server SET wipes the own workspace chat from chatReports.
+        // We bypass the narrow-layout skip for that specific case so the LHN stays correct.
+        // See issue #84248.
         if (
-            (!shouldUseNarrowLayout || orderedReportIDs.length === 0) &&
+            (!shouldUseNarrowLayout || orderedReportIDs.length === 0 || isCurrentReportOwnWorkspaceChatRef.current) &&
             derivedCurrentReportID &&
             derivedCurrentReportID !== '-1' &&
             orderedReportIDs.indexOf(derivedCurrentReportID) === -1

src/pages/inbox/ReportFetchHandler.tsx

@@ -68,6 +68,12 @@ function ReportFetchHandler() {
     const hasCreatedLegacyThreadRef = useRef(false);
     const didSubscribeToReportLeavingEvents = useRef(false);
 
+    // Track whether the current route is an own workspace chat synchronously during render.
+    // After a delegate split the server sends an Onyx SET that wipes the report; by the time a
+    // useEffect fires, report is undefined and we can no longer detect the chat type. See #84248.
+    const isCurrentRouteOwnWorkspaceChatRef = useRef(false);
+    // (Updated below after reportOnyx is read.)
+
     const [reportOnyx] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportIDFromRoute}`);
     const [chatReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportOnyx?.chatReportID}`);
     const [reportMetadata = defaultReportMetadata] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportIDFromRoute}`);
@@ -98,6 +104,16 @@ function ReportFetchHandler() {
 
     const isTransactionThreadView = isReportTransactionThread(report);
 
+    // Update the ref synchronously each render so the re-fetch effect below can read it
+    // even after the Onyx wipe has cleared `report`.
+    if (report?.reportID && report.reportID === reportIDFromRoute) {
+        isCurrentRouteOwnWorkspaceChatRef.current = !!report.isOwnPolicyExpenseChat;
+    } else if (!report?.reportID) {
+        // Report wiped — intentionally keep the last known value.
+    } else {
+        isCurrentRouteOwnWorkspaceChatRef.current = false;
+    }
+
     const indexOfLinkedMessage = reportActionIDFromRoute ? reportActions.findIndex((obj) => String(obj.reportActionID) === String(reportActionIDFromRoute)) : -1;
     const doesCreatedActionExists = !!reportActions?.findLast((action) => isCreatedAction(action));
     const isLinkedMessageAvailable = indexOfLinkedMessage > -1;
@@ -156,6 +172,20 @@ function ReportFetchHandler() {
 
     // Effect order below matches the original declaration order in ReportScreen.tsx.
 
+    // When a delegate splits an expense the server sends a temporary Onyx SET that wipes the
+    // workspace chat. The navigation guards in ReportScreen block any redirect, but the report
+    // stays blank until something re-fetches it. This effect detects the wipe and re-fetches.
+    // See issue #84248.
+    const prevReportID = usePrevious(report?.reportID);
+    useEffect(() => {
+        const wasJustWiped = !!prevReportID && prevReportID === reportIDFromRoute && !report?.reportID;
+        if (!wasJustWiped || !isCurrentRouteOwnWorkspaceChatRef.current) {
+            return;
+        }
+        fetchReport();
+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, [report?.reportID, prevReportID, reportIDFromRoute]);
+
     useEffect(() => {
         if (!transactionThreadReportID || !route?.params?.reportActionID || !isOneTransactionThread(childReport, report, linkedAction)) {
             return;

src/pages/inbox/ReportScreen.tsx

@@ -1,6 +1,6 @@
 import {PortalHost} from '@gorhom/portal';
 import {useIsFocused} from '@react-navigation/native';
-import React, {useCallback, useEffect, useMemo, useState} from 'react';
+import React, {useCallback, useEffect, useMemo, useRef, useState} from 'react';
 import type {ViewStyle} from 'react-native';
 // We use Animated for all functionality related to wide RHP to make it easier
 // to interact with react-navigation components (e.g., CardContainer, interpolator), which also use Animated.
@@ -354,6 +354,20 @@ function ReportScreen({route, navigation}: ReportScreenProps) {
     });
     const isDeletedTransactionThread = isReportTransactionThread(report) && (isParentActionDeleted || isParentActionMissingAfterLoad);
     const [deleteTransactionNavigateBackUrl] = useOnyx(ONYXKEYS.NVP_DELETE_TRANSACTION_NAVIGATE_BACK_URL);
+
+    // Track whether the current route is an own workspace chat (isOwnPolicyExpenseChat).
+    // Must be a ref set synchronously during render — by the time the navigation effects fire
+    // after a delegate split, the server SET has wiped report/prevReport in Onyx so we can't
+    // rely on live state or usePrevious. See issue #84248.
+    const isCurrentRouteOwnWorkspaceChatRef = useRef(false);
+    if (report?.reportID && report.reportID === reportIDFromRoute) {
+        isCurrentRouteOwnWorkspaceChatRef.current = !!report.isOwnPolicyExpenseChat;
+    } else if (!report?.reportID) {
+        // Report wiped by Onyx SET — intentionally keep the last known value.
+    } else {
+        isCurrentRouteOwnWorkspaceChatRef.current = false;
+    }
+
     // eslint-disable-next-line rulesdir/no-negated-variables
     const shouldShowNotFoundLinkedAction =
         (!isLinkedActionInaccessibleWhisper && isLinkedActionDeleted && isNavigatingToDeletedAction) ||
@@ -473,7 +487,10 @@ function ReportScreen({route, navigation}: ReportScreenProps) {
             isEmpty(report) &&
             (isMoneyRequest(prevReport) ||
                 isMoneyRequestReport(prevReport) ||
-                isPolicyExpenseChat(prevReport) ||
+                // Own policy expense chats (workspace chats) are excluded: a vacation delegate
+                // splitting an expense sends a temporary server SET that wipes the report, but
+                // the chat was never intentionally removed. See issue #84248.
+                (isPolicyExpenseChat(prevReport) && !prevReport?.isOwnPolicyExpenseChat) ||
                 isGroupChat(prevReport) ||
                 isAdminRoom(prevReport) ||
                 isAnnounceRoom(prevReport));
@@ -566,6 +583,22 @@ function ReportScreen({route, navigation}: ReportScreenProps) {
             return;
         }
 
+        // Do not navigate away for own workspace chats — a delegate split causes a temporary
+        // Onyx wipe that looks like a deletion but the chat was never actually removed.
+        // See issue #84248.
+        if (isCurrentRouteOwnWorkspaceChatRef.current) {
+            return;
+        }
+
+        // Clean up the navigation stack before redirecting to prevent an infinite loop where
+        // pressing back returns to the wiped report URL and re-triggers this effect.
+        Navigation.dismissModal();
+        if (Navigation.getTopmostReportId() === reportIDFromRoute) {
+            Navigation.isNavigationReady().then(() => {
+                Navigation.popToSidebar();
+            });
+        }
+
         // Try to navigate to parent report if available
         if (deletedReportParentID && !isMoneyRequestReportPendingDeletion(deletedReportParentID)) {
             Navigation.isNavigationReady().then(() => {
@@ -578,7 +611,7 @@ function ReportScreen({route, navigation}: ReportScreenProps) {
         Navigation.isNavigationReady().then(() => {
             navigateToConciergeChat(conciergeReportID, introSelected, currentUserAccountID, isSelfTourViewed, betas);
         });
-    }, [reportWasDeleted, isFocused, deletedReportParentID, conciergeReportID, introSelected, currentUserAccountID, isSelfTourViewed, betas]);
+    }, [reportWasDeleted, isFocused, deletedReportParentID, conciergeReportID, introSelected, currentUserAccountID, isSelfTourViewed, betas, reportIDFromRoute]);
 
     const actionListValue = useActionListContextValue();