Skip to content

[No QA] Add help site article for Expensify Card Spend Rules#87548

Open
MelvinBot wants to merge 1 commit intomainfrom
melvinbot-helpsite-spend-rules
Open

[No QA] Add help site article for Expensify Card Spend Rules#87548
MelvinBot wants to merge 1 commit intomainfrom
melvinbot-helpsite-spend-rules

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

  • Adds a new help article (Expensify-Card-Spend-Rules.md) documenting the Spend Rules feature introduced in Add spend rule base page #86684
  • Updates the existing Workspace-Rules.md article to include a section about Spend Rules with a link to the new article

Details

PR #86684 adds a "Spend" section to the Workspace Rules page that lets Workspace Admins create rules to approve or decline Expensify Card transactions in real time based on merchants, spend categories, or max amounts. The new help article covers:

  • Built-in card protections (adult services, ATMs, gambling, money transfers)
  • How to create custom spend rules (restriction type, merchants, categories, max amount)
  • How spend rules work (allow vs block, real-time evaluation)
  • FAQ (visibility, currency requirements, available categories)

Written following HELP_AUTHORING_GUIDELINES.md, HELPSITE_NAMING_CONVENTIONS.md, and TEMPLATE.md.

Test plan

  • Verify the new article renders correctly on the help site
  • Verify all UI labels match the current app (button names, section names, navigation paths)
  • Verify cross-links between Workspace-Rules.md and the new article work correctly

Adds a new help article documenting the Expensify Card Spend Rules feature
and updates the existing Workspace Rules article to reference it.

Co-authored-by: Carlos Martins <[email protected]>

---

# How to configure Expensify Card Spend Rules
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heading level violation: Per HELP_AUTHORING_GUIDELINES.md Section 4, articles must have "exactly one # heading (the article title). No other # headings are allowed except # FAQ." This should be demoted to ## to comply with governance rules.

Note: The existing file already uses multiple # headings (a pre-existing pattern), but governance specifies only ## for content sections below the title. Consider addressing this across the file in a follow-up.


The **Spend** section appears on the Rules page when Expensify Cards are enabled for the workspace.

To learn how to create and manage Spend Rules, see:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-link violation: Per HELP_AUTHORING_GUIDELINES.md Section 7 (Link Formatting), "Use relative links only. Do not use full URLs."

Replace:

Suggested change
To learn how to create and manage Spend Rules, see:
[**Expensify Card Spend Rules**](/articles/new-expensify/workspaces/Expensify-Card-Spend-Rules)


1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), click **Workspaces**.
2. Click your **workspace name**.
3. Click **Rules**.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation phrasing: Per HELPSITE_NAMING_CONVENTIONS.md, the unified navigation instruction should follow this format: "Click the navigation tabs (on the left on web, on the bottom on mobile)." The current phrasing restructures this as "In the navigation tabs... click Workspaces" and adds "and" before "at the bottom."

Suggested fix:

Suggested change
3. Click **Rules**.
1. Click **Workspaces** in the navigation tabs (on the left on web, on the bottom on mobile).


1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), click **Workspaces**.
2. Click your **workspace name**.
3. Click **Rules**.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation phrasing: Same as above — align with governance format.

Suggested fix:

Suggested change
3. Click **Rules**.
1. Click **Workspaces** in the navigation tabs (on the left on web, on the bottom on mobile).

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new standalone article for Expensify Card Spend Rules and a cross-link section in the existing Workspace-Rules.md article. The new article is well-structured, follows a clear single-workflow focus, and demonstrates strong metadata practices. There are a few issues that should be addressed before merging, with one critical cross-linking violation and one heading concern in the Workspace-Rules.md changes.

Scores Summary

  • Readability: 9/10 - Clear, scannable steps with logical flow. The intro paragraph sets context well, bullet lists are used effectively, and the FAQ answers are concise and direct. Step 7 sub-items are well-organized for a multi-option configuration.
  • AI Readiness: 9/10 - Strong YAML metadata with a well-scoped internalScope field. Keywords cover realistic search phrases. Multiple "How to" headings include the feature name. The one heading that lacks a task-based verb ("How Expensify Card Spend Rules work") still includes the feature name and a question-adjacent phrasing that aids retrieval.
  • Style Compliance: 7/10 - Mostly strong UI referencing with correct bolding and casing. Loses points for the full URL cross-link (critical violation) and the heading level issue in Workspace-Rules.md.

Key Findings

Issues to address:

  1. [Critical] Full URL instead of relative link in Workspace-Rules.md -- The cross-link uses https://help.expensify.com/articles/new-expensify/workspaces/Expensify-Card-Spend-Rules which violates the cross-linking standard in HELP_AUTHORING_GUIDELINES.md Section 7: "Use relative links only. Do not use full URLs." This should be a relative path such as /articles/new-expensify/workspaces/Expensify-Card-Spend-Rules.

  2. [Moderate] Heading level in Workspace-Rules.md -- The added section uses # How to configure Expensify Card Spend Rules (H1). The governance spec requires exactly one # heading per article (the title) plus # FAQ. However, the existing Workspace-Rules.md already uses multiple # headings throughout (e.g., # How to configure Expense Report rules, # How to configure Workspace Merchant Rules). The new heading is consistent with the file's established pattern, but this pattern itself deviates from the spec. At minimum, the new addition should match whatever heading level is decided for this file. If the file is eventually brought into compliance, all these # headings would become ##.

  3. [Minor] Heading "How Expensify Card Spend Rules work" -- Per HELP_AUTHORING_GUIDELINES.md Section 2, all headings (except # FAQ) must start with an action verb or question word. "How... work" is borderline -- it reads more as explanatory than task-based. Consider rephrasing to something like "How Expensify Card Spend Rules evaluate transactions" or converting to a question format: "What happens when Expensify Card Spend Rules are evaluated?" That said, this phrasing is explicitly listed as acceptable in TEMPLATE.md ("How [Exact Feature Name nuance] works"), so this is a minor observation rather than a required fix.

  4. [Minor] Navigation phrasing -- The article uses "In the navigation tabs (on the left on web, and at the bottom on mobile), click Workspaces." The canonical governance phrasing is "Click the navigation tabs (on the left on web, on the bottom on mobile)." The article's phrasing adds "and" before "at the bottom" and uses "In the... click" rather than "Click the...". However, this matches the exact phrasing already used in Workspace-Rules.md line 20. For consistency within the file this is acceptable, but worth noting the deviation from the canonical form.

What is done well:

  • Excellent YAML metadata -- the internalScope field clearly defines audience, coverage, and exclusions, which is exactly what the spec requires.
  • Strong single-workflow focus. The article covers spend rules only and explicitly excludes card setup and general expense rules.
  • Good FAQ section with question-format headings that address real user scenarios.
  • UI terminology appears accurate with correct bolding of button names (Save rule, Add spend rule, Next), section names (Spend), and feature names (Expensify Cards).
  • The "Who can use" section clearly states prerequisites (role, plan, feature dependencies).
  • Keywords are realistic and cover a good range of search terms.
  • The cross-link section in Workspace-Rules.md provides useful context before linking out, following the pattern of explaining the feature briefly and directing to the dedicated article.

Recommendations

  1. Required: Convert the full URL in Workspace-Rules.md to a relative link.
  2. Recommended: Consider whether the # heading level in Workspace-Rules.md should be ## for governance compliance, understanding this is a broader file-level issue.
  3. Optional: Revisit the "How Expensify Card Spend Rules work" heading if a more action-oriented phrasing feels natural.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Expensify-Card-Spend-Rules.md (new, 82 lines) -- Well-structured new article with strong metadata and clear procedural steps. One minor heading observation.
  • docs/articles/new-expensify/workspaces/Workspace-Rules.md (11 lines added) -- Cross-link section with a critical URL format issue and a heading level concern consistent with pre-existing file patterns.

Review based on governance rules defined in docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md.

@github-actions github-actions bot changed the title Add help site article for Expensify Card Spend Rules [No QA] Add help site article for Expensify Card Spend Rules Apr 10, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://fff4ba7e.helpdot.pages.dev ⚡️

Updated articles:

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c8583b3ba

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +49 to +50
5. Click **Add spend rule**.
6. Select the cards this rule applies to, then click **Next**.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restrict custom-rule instructions to current rollout scope

This article instructs admins to click Add spend rule, but that action is not available in production today: src/pages/workspace/rules/SpendRules/SpendRulesSection.tsx renders the add button only when !isProduction (lines 265–275). Because this is a public help page under docs/articles/new-expensify/..., production users will hit a dead-end flow and be unable to follow the documented steps. Please gate the documentation to beta/non-production users or remove the creation steps until production exposes the button.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants