[No QA] Add help site article for Expensify Card Spend Rules#87548
[No QA] Add help site article for Expensify Card Spend Rules#87548
Conversation
Adds a new help article documenting the Expensify Card Spend Rules feature and updates the existing Workspace Rules article to reference it. Co-authored-by: Carlos Martins <[email protected]>
|
|
||
| --- | ||
|
|
||
| # How to configure Expensify Card Spend Rules |
There was a problem hiding this comment.
Heading level violation: Per HELP_AUTHORING_GUIDELINES.md Section 4, articles must have "exactly one # heading (the article title). No other # headings are allowed except # FAQ." This should be demoted to ## to comply with governance rules.
Note: The existing file already uses multiple # headings (a pre-existing pattern), but governance specifies only ## for content sections below the title. Consider addressing this across the file in a follow-up.
|
|
||
| The **Spend** section appears on the Rules page when Expensify Cards are enabled for the workspace. | ||
|
|
||
| To learn how to create and manage Spend Rules, see: |
There was a problem hiding this comment.
Cross-link violation: Per HELP_AUTHORING_GUIDELINES.md Section 7 (Link Formatting), "Use relative links only. Do not use full URLs."
Replace:
| To learn how to create and manage Spend Rules, see: | |
| [**Expensify Card Spend Rules**](/articles/new-expensify/workspaces/Expensify-Card-Spend-Rules) |
|
|
||
| 1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), click **Workspaces**. | ||
| 2. Click your **workspace name**. | ||
| 3. Click **Rules**. |
There was a problem hiding this comment.
Navigation phrasing: Per HELPSITE_NAMING_CONVENTIONS.md, the unified navigation instruction should follow this format: "Click the navigation tabs (on the left on web, on the bottom on mobile)." The current phrasing restructures this as "In the navigation tabs... click Workspaces" and adds "and" before "at the bottom."
Suggested fix:
| 3. Click **Rules**. | |
| 1. Click **Workspaces** in the navigation tabs (on the left on web, on the bottom on mobile). |
|
|
||
| 1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), click **Workspaces**. | ||
| 2. Click your **workspace name**. | ||
| 3. Click **Rules**. |
There was a problem hiding this comment.
Navigation phrasing: Same as above — align with governance format.
Suggested fix:
| 3. Click **Rules**. | |
| 1. Click **Workspaces** in the navigation tabs (on the left on web, on the bottom on mobile). |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new standalone article for Expensify Card Spend Rules and a cross-link section in the existing Workspace-Rules.md article. The new article is well-structured, follows a clear single-workflow focus, and demonstrates strong metadata practices. There are a few issues that should be addressed before merging, with one critical cross-linking violation and one heading concern in the Workspace-Rules.md changes. Scores Summary
Key FindingsIssues to address:
What is done well:
Recommendations
Files Reviewed
Review based on governance rules defined in docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md. |
|
A preview of your ExpensifyHelp changes have been deployed to https://fff4ba7e.helpdot.pages.dev ⚡️ Updated articles: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c8583b3ba
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 5. Click **Add spend rule**. | ||
| 6. Select the cards this rule applies to, then click **Next**. |
There was a problem hiding this comment.
Restrict custom-rule instructions to current rollout scope
This article instructs admins to click Add spend rule, but that action is not available in production today: src/pages/workspace/rules/SpendRules/SpendRulesSection.tsx renders the add button only when !isProduction (lines 265–275). Because this is a public help page under docs/articles/new-expensify/..., production users will hit a dead-end flow and be unable to follow the documented steps. Please gate the documentation to beta/non-production users or remove the creation steps until production exposes the button.
Useful? React with 👍 / 👎.
Summary
Expensify-Card-Spend-Rules.md) documenting the Spend Rules feature introduced in Add spend rule base page #86684Workspace-Rules.mdarticle to include a section about Spend Rules with a link to the new articleDetails
PR #86684 adds a "Spend" section to the Workspace Rules page that lets Workspace Admins create rules to approve or decline Expensify Card transactions in real time based on merchants, spend categories, or max amounts. The new help article covers:
Written following
HELP_AUTHORING_GUIDELINES.md,HELPSITE_NAMING_CONVENTIONS.md, andTEMPLATE.md.Test plan