Skip to content

[No QA] Add help site docs for Duplicate Report feature#87835

Merged
kadiealexander merged 4 commits intomainfrom
claude-helpSiteDuplicateReport
Apr 15, 2026
Merged

[No QA] Add help site docs for Duplicate Report feature#87835
kadiealexander merged 4 commits intomainfrom
claude-helpSiteDuplicateReport

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Explanation of Change

Add help site documentation for the Duplicate Report feature (tracked in #81206). This covers 5 merged implementation issues:

  1. New article How-to-Duplicate-a-Report.md — documents the new "Duplicate report" action available in the report More menu, including what gets copied, workspace behavior, and FAQ.
  2. Update Expense-and-Report-Actions.md — adds "Duplicate report" row to the Secondary Actions table.
  3. Update Understanding-Report-Statuses-and-Actions.md — adds "Duplicate report" to the More menu bullet list.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/623952

Tests

  • Verify docs routes validation passes (createDocsRoutes.sh)
  • Verify new article follows existing patterns (matches structure of How-to-Duplicate-an-Expense.md)
  • Verify table row in Expense-and-Report-Actions.md matches column format of existing rows

Offline tests

N/A — docs-only changes, no runtime behavior.

QA Steps

  1. Verify the new article renders correctly on the help site
  2. Verify the updated tables in Expense-and-Report-Actions.md and Understanding-Report-Statuses-and-Actions.md display correctly
  • Verify that no errors appear in the JS console

AI Tests

  • createDocsRoutes.shpassed (docs routes file is up to date)

Human Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"

QA

// TODO: The human co-author must fill out the QA tests before marking this PR as "ready for review"

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

Add new article How-to-Duplicate-a-Report.md covering the new
Duplicate report action, and update Expense-and-Report-Actions.md
and Understanding-Report-Statuses-and-Actions.md to include the
new action in their reference tables.

Co-authored-by: Stephanie Elliott <[email protected]>
@MelvinBot MelvinBot requested a review from a team April 14, 2026 06:34
@github-actions github-actions bot changed the title Add help site docs for Duplicate Report feature [No QA] Add help site docs for Duplicate Report feature Apr 14, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 14, 2026

@stephanieelliott stephanieelliott marked this pull request as ready for review April 15, 2026 02:43
@stephanieelliott stephanieelliott self-requested a review as a code owner April 15, 2026 02:43
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 15, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @lschurr

@melvin-bot melvin-bot bot requested review from lschurr and removed request for a team April 15, 2026 02:43
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 15, 2026

@lschurr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Comment thread docs/articles/new-expensify/reports-and-expenses/Duplicate-a-Report.md Outdated
Comment thread docs/articles/new-expensify/reports-and-expenses/Duplicate-a-Report.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new help article for the Duplicate Report feature along with corresponding cross-reference entries in two existing articles. The new article is well-structured, follows the single-workflow principle, and includes all required YAML metadata. However, there are several governance violations that need to be addressed before merge, most notably the use of prohibited "More" terminology instead of the required three dots convention.

Scores Summary

  • Readability: 8/10 - The article is clear, scannable, and well-organized with logical sections. Minor issue: a missing space after the period in the intro paragraph ("Duplicate report.This" should be "Duplicate report. This"). Step instructions are mostly action-oriented and sequential.
  • AI Readiness: 9/10 - All YAML metadata fields are present and well-crafted, including internalScope with clear audience and exclusions. Headings are task-based using action verbs and question words. Includes a "How to" heading. Keywords cover realistic search phrases.
  • Style Compliance: 5/10 - Multiple governance violations found: (1) Step 4 uses "Select More" which is explicitly prohibited -- must use "Select the three dots (⋮)"; (2) FAQ heading references "More menu" which is also prohibited; (3) Navigation instruction phrasing deviates from the prescribed format; (4) Quotation marks used inside bold UI reference text.

Key Findings

Critical issues that must be addressed:

  • Three Dots Menu Rule violation (Step 4): "Select More" must be changed to "Select the three dots (⋮)" per HELPSITE_NAMING_CONVENTIONS.md. The governance file explicitly states: "Do not call it 'More'" and "Do not write 'More menu'."
  • FAQ heading references prohibited term: "Why is the Duplicate report option not showing in the More menu?" uses "More menu" which is prohibited. Suggested revision: "Why is Duplicate report not showing after selecting the three dots on my report?"
  • Navigation phrasing mismatch (Step 1): "In the navigation tabs (on the left on web, and at the bottom on mobile)" does not match the prescribed format. Per governance, when web and mobile are structurally the same, use: "Click the navigation tabs (on the left on web, on the bottom on mobile)." The word "Click" should begin the instruction, "and at" should be just "on," and "In" should not be used.

Minor issues:

  • Missing space: In the intro paragraph, "Duplicate report.This" is missing a space before "This."
  • Quotation marks in UI reference: **"Copy of [Original report name]"** wraps the UI element name in quotation marks. Per Button Naming Standards, UI elements should not be wrapped in quotation marks. Consider: The new report is named Copy of [Original report name].
  • Inconsistent Workspace capitalization: In the "What happens" section, one bullet uses lowercase "workspace" ("the new report is created on that workspace") while another uses capitalized "Workspace" ("created on your primary Workspace"). Per naming conventions, use the exact term as shown in the UI consistently.
  • Step 2 vagueness: "Locate the report you want to duplicate" is borderline against the prohibited language rule ("Find the setting"). Consider making this more deterministic, e.g., "Click the report you want to duplicate" (which also makes Step 3 redundant, streamlining the flow).

Positive aspects:

  • Thorough internalScope metadata that clearly defines audience, coverage, and exclusions
  • Good cross-link to the individual expense duplication article, placed outside numbered steps as required
  • FAQ section addresses realistic user questions with direct, concise answers
  • The additions to Expense-and-Report-Actions.md and Understanding-Report-Statuses-and-Actions.md are consistent and well-formatted
  • Clean heading hierarchy using only # and ## levels as required
  • Single-workflow focus maintained throughout the article

Recommendations

  1. [Must fix] Replace "Select More" in Step 4 with "Select the three dots (⋮)"
  2. [Must fix] Rewrite the FAQ heading to remove "More menu" reference
  3. [Must fix] Revise Step 1 navigation phrasing to match the prescribed format exactly
  4. [Should fix] Add the missing space after the period in the intro paragraph
  5. [Should fix] Remove quotation marks from the bold UI element name in the "What happens" section
  6. [Should fix] Standardize "Workspace" capitalization throughout
  7. [Consider] Consolidate Steps 2 and 3 into a single, more deterministic step

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Duplicate-a-Report.md (new file) - Good structure and metadata; requires three dots menu and navigation phrasing fixes
  • docs/articles/new-expensify/reports-and-expenses/Expense-and-Report-Actions.md (+1 line) - Table row addition is well-formatted and consistent with existing entries
  • docs/articles/new-expensify/reports-and-expenses/Understanding-Report-Statuses-and-Actions.md (+1 line) - Bullet addition is appropriate and correctly placed

Scoring is based on the governance rules defined in docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md.

@stephanieelliott
Copy link
Copy Markdown
Contributor

Applied all relevant bot comments

@stephanieelliott
Copy link
Copy Markdown
Contributor

@garrettmknight gonna get this merged ASAP because it's being linked in the product update post tomorrow. But tagging you in here in case there is anything that needs to change - if so we can open up a followup PR

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fea345c371

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread docs/articles/new-expensify/reports-and-expenses/Duplicate-a-Report.md Outdated
@stephanieelliott stephanieelliott removed the request for review from lschurr April 15, 2026 03:12
@kadiealexander kadiealexander merged commit 71e6430 into main Apr 15, 2026
17 checks passed
@kadiealexander kadiealexander deleted the claude-helpSiteDuplicateReport branch April 15, 2026 03:19
@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/kadiealexander in version: 9.3.60-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants