Fix - Android - Chat - Composer is no longer highlighted after rotation, emoji picker does not open#88122
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05d5061e35
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (prevIsInLandscapeMode !== isInLandscapeMode && isInLandscapeMode) { | ||
| setTimeout(() => inputRef.current?.focus?.(), ROTATION_REFOCUS_DELAY_MS); |
There was a problem hiding this comment.
Gate refocus to rotation-triggered blur only
The current condition refocuses on any blur while prevIsInLandscapeMode !== isInLandscapeMode && isInLandscapeMode, not specifically the blur caused by rotation. That means after rotating to landscape, a normal user blur (e.g., tapping outside to dismiss the keyboard) can be immediately undone by the timeout focus, causing the keyboard to pop back up and making blur behavior unreliable. This is especially visible when the OS does not emit an automatic blur during rotation, because the first intentional blur gets treated as a rotation blur.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
While technically true, this is designed to address a specific case because that blur occurs on android. Couldn't reproduce scenario described above while testing.
GCyganek
left a comment
There was a problem hiding this comment.
LGTM, let's start with this 👍
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-17.at.10.58.23.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-04-17.at.11.04.58.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Explanation of Change
Fixed Issues
$ #87807
PROPOSAL:
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-16.at.16.08.42.mov