[No QA] Preserve chat reading position when new messages arrive#88132
Draft
sosek108 wants to merge 1 commit intoExpensify:mainfrom
Draft
[No QA] Preserve chat reading position when new messages arrive#88132sosek108 wants to merge 1 commit intoExpensify:mainfrom
sosek108 wants to merge 1 commit intoExpensify:mainfrom
Conversation
7 tasks
situchan
reviewed
Apr 16, 2026
| keyExtractor={keyExtractor} | ||
| drawDistance={1500} | ||
| maintainVisibleContentPosition={{ | ||
| autoscrollToTopThreshold: 10, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When a user scrolls up in a chat to read older messages, new incoming messages caused the list to jump, displacing the content being read. Adding
maintainVisibleContentPositionwithautoscrollToTopThreshold: 10anchors the viewport to the currently visible content when new items arrive above it. TheautoscrollToTopThreshold: 10value ensures that if the user is near the live end of the feed (within 10px), the list still auto-scrolls to show new messages — preserving the expected live-chat behavior. No changes to data fetching, rendering logic, or message ordering were needed.Fixed Issues
$ #88089
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari