Fix iOS crash caused by navigation race condition after Onfido exit#88184
Closed
pranjal2410719 wants to merge 1 commit intoExpensify:mainfrom
Closed
Fix iOS crash caused by navigation race condition after Onfido exit#88184pranjal2410719 wants to merge 1 commit intoExpensify:mainfrom
pranjal2410719 wants to merge 1 commit intoExpensify:mainfrom
Conversation
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
👋 Hi @pranjal2410719, thanks for your interest in contributing to Expensify! This PR has been automatically closed because it doesn't appear to meet our contribution requirements:
If you'd like to contribute, please make sure to:
Please review our contributing guidelines for more details. If you believe this was closed in error, please reach out in the #expensify-open-source Slack channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
On iOS, the Onfido SDK triggers the exit callback before its native view controller has fully completed dismissal. The existing implementation immediately called
onUserExit, which triggered React Navigation transitions while the native dismissal animation was still in progress.This created a race condition between:
iOS does not allow overlapping view controller transitions, resulting in a crash.
This PR introduces a deferred exit mechanism to synchronize navigation with the completion of native interactions.
Fixed Issues
$ #88173
PROPOSAL: #88173 (comment)
Fix
scheduleUserExitto defer navigation on iOSInteractionManager.runAfterInteractionsto wait for ongoing interactionsrequestAnimationFramechaining to align with render cycleisExitInProgress) to prevent duplicate triggersAndroid behavior remains unchanged.
Tests
Offline tests
QA Steps
Same as Tests