Spend rule card empty state by cretadn22 · Pull Request #88256 · Expensify/App

cretadn22 · 2026-04-18T15:50:34Z

Explanation of Change

Cards empty state will show "No Expensify cards issued" when workspace has no card.
Cards empty state will show nothing when workspace has eligible card and no search found

Fixed Issues

$ #87800
PROPOSAL:

Tests

Precondition:

Workspace is set up with Expensify Card feature, but no Expensify card is assigned.
Rules are enabled.

Go to staging.new.expensify.com
Go to workspace settings > Rules.
Click Add spend rule.
Click Choose cards.
Cards empty state will show "No Expensify cards issued" when workspace has no card.
Cards empty state will show nothing when workspace has eligible card and no search found

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

Workspace is set up with Expensify Card feature, but no Expensify card is assigned.
Rules are enabled.

Go to staging.new.expensify.com
Go to workspace settings > Rules.
Click Add spend rule.
Click Choose cards.
Cards empty state will show "No Expensify cards issued" when workspace has no card.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…nd rule card page Distinguish between "no cards issued" and "all cards have rules" in the SpendRuleCardPage empty state. When the workspace has no Expensify cards, show "No Expensify cards issued" instead of "All cards already have a rule". Co-authored-by: Vinh Hoang <hoangzinh@users.noreply.github.com>

Reverts the large formatting changes to locale files and applies only the actual translation diff from OSBotify for noCardsIssuedTitle and noCardsIssuedSubtitle. Co-authored-by: Vinh Hoang <hoangzinh@users.noreply.github.com>

melvin-bot · 2026-04-18T15:50:41Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-04-18T15:50:42Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8cf6f751a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-04-18T15:58:31Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...s/workspace/rules/SpendRules/SpendRuleCardPage.tsx	`0.00% <0.00%> (ø)`
... and 130 files with indirect coverage changes

hoangzinh · 2026-04-20T10:41:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

hoangzinh · 2026-04-20T10:41:57Z

If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

@cretadn22 can you complete this checklist?

cretadn22 · 2026-04-20T13:40:58Z

@hoangzinh Asked Spanish translation

shawnborton · 2026-04-20T15:33:14Z

cc @Expensify/marketing @jamesdeanexpensify - quick gut check, in the product, do we always say "Expensify Cards" or "Expensify cards"?

joekaufmanexpensify

Good for product

hoangzinh · 2026-04-21T12:40:25Z

@hoangzinh Asked Spanish translation

@cretadn22 ping me when this checklist is complete

cretadn22 · 2026-04-21T13:38:11Z

@hoangzinh Would you mind completing your review? It shouldn't hold us up now.

hoangzinh · 2026-04-22T14:59:45Z

Bug: When I set spend rules for all Expensify cards, then it displays "No Expensify cards issued" instead of "All cards already have a rule"

Screen.Recording.2026-04-22.at.21.58.10.mov

cretadn22 · 2026-04-24T11:40:17Z

@hoangzinh Translation is confirmed

cretadn22 · 2026-04-24T11:40:30Z

Bug: When I set spend rules for all Expensify cards, then it displays "No Expensify cards issued" instead of "All cards already have a rule"

Fixed

jamesdeanexpensify · 2026-04-24T14:41:21Z

Sorry for the delay here, was OOO. But we always say "Expensify Card" and "Expensify Cards" - it's a branded term! Thanks.

… to ensure consistent capitalization.

MelvinBot and others added 4 commits April 17, 2026 13:05

Merge branch 'main' into claude-spendRuleCardEmptyState

a06afd7

hide the block view if no result found

c8cf6f7

cretadn22 requested review from a team as code owners April 18, 2026 15:50

melvin-bot Bot assigned cretadn22 Apr 18, 2026

melvin-bot Bot requested review from hoangzinh and joekaufmanexpensify April 18, 2026 15:50

melvin-bot Bot requested review from a team and removed request for a team April 18, 2026 15:50

melvin-bot Bot requested review from heyjennahay and removed request for a team April 18, 2026 15:50

github-actions Bot reviewed Apr 18, 2026

View reviewed changes

Comment thread src/pages/workspace/rules/SpendRules/SpendRuleCardPage.tsx Outdated

chatgpt-codex-connector Bot reviewed Apr 18, 2026

View reviewed changes

Comment thread src/pages/workspace/rules/SpendRules/SpendRuleCardPage.tsx Outdated

fix prettier and remove duplicated variable

445f195

hoangzinh reviewed Apr 20, 2026

View reviewed changes

Comment thread src/pages/workspace/rules/SpendRules/SpendRuleCardPage.tsx Outdated

Update SpendRuleCardPage to use hasCards for listEmptyContent condition

fbac97b

joekaufmanexpensify previously approved these changes Apr 20, 2026

View reviewed changes

Merge branch 'main' into spendRuleCardEmptyState

c8bcbfe

Merge branch 'main' into spendRuleCardEmptyState

c07dc5a

hoangzinh mentioned this pull request Apr 24, 2026

[$250] Rules - Cards empty state shows "All cards already have a rule" when workspace has no card #87800

Open

7 tasks

Refactor SpendRuleCardPage to improve card availability checks

bd4873e

cretadn22 dismissed joekaufmanexpensify’s stale review via bd4873e April 24, 2026 11:39

cretadn22 added 2 commits April 24, 2026 18:41

Fix header message logic

9c2f334

use allCardsList

987de1c

cretadn22 force-pushed the spendRuleCardEmptyState branch from ab01f4d to 987de1c Compare April 24, 2026 11:55

fix eslint

01d36ba

Update translations for card issuance messages in English and Spanish…

d42ea26

… to ensure consistent capitalization.

Conversation

cretadn22 commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 18, 2026

Uh oh!

melvin-bot Bot commented Apr 18, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Apr 18, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hoangzinh commented Apr 20, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Apr 20, 2026

Uh oh!

Uh oh!

cretadn22 commented Apr 20, 2026

Uh oh!

shawnborton commented Apr 20, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Apr 21, 2026

Uh oh!

cretadn22 commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoangzinh commented Apr 22, 2026

Uh oh!

cretadn22 commented Apr 24, 2026

Uh oh!

cretadn22 commented Apr 24, 2026

Uh oh!

jamesdeanexpensify commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cretadn22 commented Apr 18, 2026 •

edited

Loading

codecov Bot commented Apr 18, 2026 •

edited by github-actions Bot

Loading

cretadn22 commented Apr 21, 2026 •

edited

Loading