BT: Migrate `CHANGE_APPROVER` by mananjadhav · Pull Request #88361 · Expensify/App

mananjadhav · 2026-04-20T21:19:58Z

Explanation of Change

Fixed Issues

$ #83368
PROPOSAL:

Tests

Preconditions

A workspace has approvals enabled
You are a workspace admin on that workspace’s policy.
You have an expense / money-request report that is submitted (in “processing” / submitted state), so Change approver appears in the report More (⋯) menu.

Case 1: DYNAMIC_ROUTES.REPORT_CHANGE_APPROVER

Open Expensify.
Open a report that meets the preconditions above (submitted expense report on an approved workspace).
Open the report header More (⋯) menu.
Tap Change approver.
Confirm the Change approver screen loads (URL should look like r/<reportID>/change-approver without a backTo param).
Press Back.
Confirm you return to the report you came from (same entry point as step 2).

Case 2: REPORT_CHANGE_APPROVER_ADD_APPROVER

Open Expensify.
Open a report that meets the preconditions and open Change approver (steps 2–4 from Case 1).
Choose Add approver (and complete any workspace upgrade prompt if shown, so you can reach the add-approver step).
Confirm the Add approver screen loads (URL should include change-approver/add).
Press Back.
Confirm you return to Change approver (not the report).

Verify that no errors appear in the JS console

Offline tests

Same as Test Steps

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as Test Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-change-approver.mov

Android: mWeb Chrome

mweb-chrome-change-approver.mov

iOS: Native

ios-change-approver.mov

iOS: mWeb Safari

mweb-safari-change-approver.mov

MacOS: Chrome / Safari

web-change-approver.mov

codecov · 2026-04-20T21:29:10Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/ROUTES.ts	`16.95% <ø> (+0.03%)`	⬆️
src/SCREENS.ts	`100.00% <ø> (ø)`
src/hooks/useExpenseActions.ts	`0.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
src/pages/ReportAddApproverPage.tsx	`0.00% <ø> (ø)`
src/pages/Search/SearchChangeApproverPage.tsx	`13.20% <ø> (ø)`
src/pages/inbox/report/withReportOrNotFound.tsx	`97.05% <ø> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.94% <0.00%> (ø)`
src/pages/DynamicReportChangeApproverPage.tsx	`2.77% <0.00%> (ø)`
... and 74 files with indirect coverage changes

melvin-bot · 2026-04-20T22:05:48Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-04-20T22:09:15Z

    const [reportNextStep] = useOnyx(`${ONYXKEYS.COLLECTION.NEXT_STEP}${reportID}`);
    const hasAutoAppliedRef = useRef(false);
    const hasNavigatedToAddApproverRef = useRef(false);
+    const backPath = useDynamicBackPath(DYNAMIC_ROUTES.REPORT_CHANGE_APPROVER.path);


❌ CLEAN-REACT-PATTERNS-0 (docs)

This file compiles with React Compiler (verified via check-compiler.sh). The new useCallback wrapping goBack is redundant because React Compiler automatically memoizes closures based on their captured variables.

Remove the useCallback wrapper and use a plain function instead:

const goBack = () => { Navigation.goBack(backPath); };

Reviewed at: d91fede | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

@mananjadhav Could you please update this?

@mananjadhav We only need to update this. After that, I’ll approve the PR and we can merge.

huult · 2026-04-21T07:26:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-21.at.14.16.55.mp4

Android: mWeb Chrome

Screen.Recording.2026-04-21.at.14.20.17.mp4

iOS: HybridApp

Screen.Recording.2026-04-21.at.14.24.12.mp4

iOS: mWeb Safari

Screen.Recording.2026-04-21.at.14.25.44.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-04-21.at.14.10.23.mp4

huult

LGTM!

github-actions · 2026-04-21T09:39:17Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-21T09:44:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88361.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9cb33cd-c079286-ae3585755f701bdb83c37bf9e35da0649551e6bc/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9cb33cd-c079286-0b6a58f71b26f4e9a4d10301ff0c2bafd15dc080/index.html

Web 🕸️
https://88361.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-21T09:54:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-21T11:44:17Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.61-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-21T11:45:49Z

No help site changes are required.

I reviewed the PR diff and the relevant help site articles. This PR is a purely internal navigation refactoring — migrating the CHANGE_APPROVER route to use dynamic routes. No user-facing feature names, UI labels, menu items, or documented workflows have changed.

The two help site articles that reference "Change approver" (Approve-Expenses.md and Expense-and-Report-Actions.md) describe the feature by its UI button label, which remains unchanged.

feat: migrate change approver to dynamic route

d91fede

melvin-bot bot assigned mananjadhav Apr 20, 2026

mananjadhav marked this pull request as ready for review April 20, 2026 22:05

mananjadhav requested review from a team as code owners April 20, 2026 22:05

melvin-bot bot requested review from heyjennahay and huult and removed request for a team April 20, 2026 22:05

melvin-bot bot removed the request for review from a team April 20, 2026 22:05

github-actions bot reviewed Apr 20, 2026

View reviewed changes

mananjadhav added 2 commits April 21, 2026 13:36

fix: remove useCallback

99b7ea3

fix: typo

b760d8a

huult approved these changes Apr 21, 2026

View reviewed changes

melvin-bot bot requested a review from mjasikowski April 21, 2026 08:18

mjasikowski approved these changes Apr 21, 2026

View reviewed changes

mjasikowski merged commit 9cb33cd into Expensify:main Apr 21, 2026
34 checks passed

github-actions bot mentioned this pull request Apr 21, 2026

Investigate workflow job failing on main: test / test (job 5) #88387

Closed

OSBotify mentioned this pull request Apr 21, 2026

Deploy Checklist: New Expensify 2026-04-21 #88394

Open

Conversation

mananjadhav commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Preconditions

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Apr 20, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Apr 20, 2026

Uh oh!

github-actions bot Apr 20, 2026

Choose a reason for hiding this comment

❌ CLEAN-REACT-PATTERNS-0 (docs)

Uh oh!

huult Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

huult Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

mananjadhav Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

huult commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 21, 2026

Uh oh!

github-actions bot commented Apr 21, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

MelvinBot commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mananjadhav commented Apr 20, 2026 •

edited

Loading

codecov bot commented Apr 20, 2026 •

edited by github-actions bot

Loading

huult commented Apr 21, 2026 •

edited

Loading