perf(tests/rust): share tables at module level and remove in-test deletes#197
Open
pdf-amzn wants to merge 1 commit into
Open
perf(tests/rust): share tables at module level and remove in-test deletes#197pdf-amzn wants to merge 1 commit into
pdf-amzn wants to merge 1 commit into
Conversation
…etes
- lsi.rs: share one LSI table and one hash-only GSI table across all
tests using AsyncOnceCell; isolate via unique partition keys (7→2 tables)
- test_base.rs: adaptive polling in wait_for_active/wait_for_deleted
(100ms for ExtendDB, 1s for DynamoDB); add comment explaining why
tests don't delete their own tables
- gsi_more.rs: remove delete_table + wait_for_deleted after assertions
- authorization.rs, backup_restore.rs, capacity_throttling.rs,
query_more.rs: remove fire-and-forget delete_table calls
Table cleanup is handled by devtools/run-tests post-run script.
In CI, the PostgreSQL container is discarded after each run anyway.
Verified: 344 passed, 0 failed, 10 ignored (ExtendDB)
333 passed, 11 failed, 10 ignored (DynamoDB — pre-existing)
pdf-amzn
requested review from
LeeroyHannigan,
amrith,
c33howard,
jcshepherd and
yesyayen
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests using AsyncOnceCell; isolate via unique partition keys (7→2 tables)
(100ms for ExtendDB, 1s for DynamoDB); add comment explaining why
tests don't delete their own tables
query_more.rs: remove fire-and-forget delete_table calls
Table cleanup is handled by devtools/run-tests post-run script.
In CI, the PostgreSQL container is discarded after each run anyway.
Verified: 344 passed, 0 failed, 10 ignored (ExtendDB)
333 passed, 11 failed, 10 ignored (DynamoDB — pre-existing)
What
Reuses tables within a module across tests, in our Rust-based integration-test suite.
Why
Make tests faster, so people are more likely to run them.
Testing done
Ran these tests
Checklist
cargo test --workspace)This needs to be done in bulk later (and GitHub enforcement added:
cargo fmt --check)cargo clippy -- -W clippy::pedantic)ADR / RFC: n/a
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache License 2.0 and I agree to the Developer Certificate of
Origin (DCO). See CONTRIBUTING.md for details.