task: web server v2 additional args #105
Conversation
Update load balancer SSL policy to `ELBSecurityPolicy-TLS13-1-2-2021-06` (enforces TLS 1.2+/TLS 1.3, modern ciphers, improved security and performance).
| }); | ||
|
|
||
| const webServerWithDomain = new studion.WebServerBuilder(`web-server-domain`) | ||
| .configureWebServer('nginxdemos/nginx-hello:plain-text', 8080) |
There was a problem hiding this comment.
Should nginxdemos/nginx-hello:plain-text be a defined constant as it is reused multiple times in the same file?
| privateZone: false, | ||
| }); | ||
|
|
||
| const webServerWithDomain = new studion.WebServerBuilder(`web-server-domain`) |
There was a problem hiding this comment.
| const webServerWithDomain = new studion.WebServerBuilder(`web-server-domain`) | |
| const webServerWithCustomDomain = new studion.WebServerBuilder(`web-server-domain`) |
just because we use customDomain inside web server component 🤔
definitely if you decide to change the name then don't forget to update it on other places also
| if ((domain || certificate) && !hostedZoneId) { | ||
| throw new Error( | ||
| 'WebServer:hostedZoneId must be provided when the domain is specified', | ||
| 'WebServer: hostedZoneId must be provided when domain or certificate are provided', |
There was a problem hiding this comment.
| 'WebServer: hostedZoneId must be provided when domain or certificate are provided', | |
| 'HostedZoneId must be provided when domain or certificate are provided', |
🤔
| }, | ||
| { parent: this }, | ||
| ), | ||
| ), |
There was a problem hiding this comment.
To improve readability I would suggest storing created record to a separate variable and then use it in the return statement
const record = new aws.route53.Record(
...
return {
primary: pulumi.output(record),or something like that
| { parent: this }, | ||
| ), | ||
| ), | ||
|
|
| delayFirstAttempt: true, | ||
| numOfAttempts: 10, | ||
| startingDelay: 2000, | ||
| timeMultiple: 2, | ||
| jitter: 'full', |
There was a problem hiding this comment.
I noticed that in tests for other components this is part of the test context config so maybe we should do the same here to be consistent 👍
Changes: