feat: DB v2 test default db #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandryllo
force-pushed
the
feat/db-v2-builder
branch
from
b052530 to
63c1af7
Compare
mandryllo
added
🚧 Work in progress
Don't merge
mandryllo
force-pushed
the
feat/db-v2-tests
branch
from
59312da to
04800c7
Compare
# Conflicts: # src/v2/components/database/index.ts
This reverts commit f361e34.
mandryllo
force-pushed
the
feat/db-v2-tests
branch
from
04800c7 to
41783a5
Compare
bornast
requested changes
Jan 2, 2026
| ); | ||
| assert.strictEqual( | ||
| instance.engineVersion, | ||
| '17.2', |
Member
There was a problem hiding this comment.
Maybe we could export defaults and assert those values directly here like we did for example in redis tests?
Collaborator
Author
There was a problem hiding this comment.
I don't like to use config for the thing I'm testing 🤔
@droguljic do you have an opinion on this?
Contributor
There was a problem hiding this comment.
I wouldn't do as suggested, as it is not considered a good practice, and it can give false negatives. Just keep it as is.
tests/database/index.test.ts
Outdated
Comment on lines
35
to
38
| after(() => automation.destroy(programArgs)); | ||
|
|
||
| describe('Default database', () => testDefaultDb(ctx)); | ||
| after(() => cleanupSnapshots(ctx)); |
Member
There was a problem hiding this comment.
Could we move both of these inside one after hook?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the third one in order to resolve #70 and it will represent type tests and default db integration tests