Skip to content

Enable proxy access management extension #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

MiroDojkic
Copy link
Member

@MiroDojkic MiroDojkic commented Mar 26, 2021

This PR:

is an attempt to achieve the following goals:

  • decouple storage and proxy modules from the rest of the Tailor services, so we can package them and make them reusable in any Node app
  • enable developers to extend proxy's access management implementation; for example, to add new allowed resources, we need to add the resource along with the cookie to identify it (so we don't need to decrypt the signature cookie each time we want to verify if the resource is allowed)
  • enable developers to extend storage service; for example, to specialize the service instance to save files in a specific folder
  • support proxying multiple storages

🔖 Todos:

  • decouple access management from the proxy
  • add proxy support for multiple storages
  • enable extension of the proxy access manager
  • decouple storage from storage middleware to support mounting on different paths
  • parametrize upload mixin to enable passing repositoryIdoption
  • enable removing all proxy cookies
  • enable adding allowed resources without deleting previous resources in the storage cookies
  • create repository-specific UploadProvider component that always saves asset in the appropriate repository folder
  • update assets migration script

@MiroDojkic MiroDojkic force-pushed the chore/proxy-access-manager-refactor branch 4 times, most recently from 62ce75e to 8997cb2 Compare March 29, 2021 09:49
@MiroDojkic MiroDojkic force-pushed the chore/proxy-access-manager-refactor branch from f60a50b to 70dc95d Compare March 31, 2021 09:33
Base automatically changed from feature/repository-assets-permission to develop March 31, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant