fix: use wildcard CORS origin for WHIP/WHEP endpoints#193
Merged
Conversation
Simplify CORS headers to use Access-Control-Allow-Origin: * instead of reflecting the request Origin. These are open protocol endpoints authenticated by Bearer tokens, not cookies, so wildcard is safe and more standard. Co-Authored-By: Claude Opus 4.6 <[email protected]>
LucasMaupin
force-pushed
the
fix/whip-whep-cors-wildcard
branch
from
e6ac741 to
bf37d36
Compare
birme
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Access-Control-Allow-Origin: *Originheader check — headers are now set unconditionally on all responses from these routesChanged files
src/api_whip.ts*, removeif (origin)guardsrc/api_whep.ts*, removeif (origin)guardTest plan
yarn testpasses (13 files, 205 tests)curl -v -X OPTIONS <url>/api/v1/whip/...returnsAccess-Control-Allow-Origin: *🤖 Generated with Claude Code