feat: remove path if empty after edit

F-star · Feb 19, 2024 · cfe753d · cfe753d
1 parent bde25ae
commit cfe753d
Showing 1 changed file with 21 additions and 2 deletions.
diff --git a/packages/core/src/path_editor/path_editor.ts b/packages/core/src/path_editor/path_editor.ts
@@ -1,6 +1,7 @@
 import { parseHexToRGBA } from '@suika/common';
 import { getRotatedRectByTwoPoint, IPoint, isPointEqual } from '@suika/geo';
 
+import { RemoveGraphsCmd } from '../commands';
 import { ControlHandle } from '../control_handle_manager';
 import { Editor } from '../editor';
 import { Ellipse, Graph, Line, Path, Rect } from '../graphs';
@@ -31,12 +32,18 @@ export class PathEditor {
     this.editor.sceneGraph.showSelectedGraphsOutline = false;
     this.editor.sceneGraph.highlightLayersOnHover = false;
 
+    this.unbindHotkeys();
     this.bindHotkeys();
     this.editor.selectedElements.on('itemsChange', this.onSelectedChange);
-    // 监听
   }
   inactive() {
+    if (!this._active) {
+      return;
+    }
+
     this._active = false;
+    this.removePathIfEmpty();
+
     this.path = null;
     this.editor.sceneGraph.showSelectedGraphsOutline = true;
     this.editor.sceneGraph.highlightLayersOnHover = true;
@@ -45,10 +52,21 @@ export class PathEditor {
     this.unbindHotkeys();
     this.editor.selectedElements.off('itemsChange', this.onSelectedChange);
   }
-
+  private removePathIfEmpty() {
+    if (
+      this.path &&
+      (this.path.pathData.length === 0 ||
+        this.path.pathData.every((item) => item.length <= 1))
+    ) {
+      this.editor.commandManager.pushCommand(
+        new RemoveGraphsCmd('remove empty path', this.editor, [this.path]),
+      );
+    }
+  }
   private bindHotkeys() {
     const editor = this.editor;
 
+    this.eventTokens = [];
     // delete / backspace: delete selected segments
     const token = editor.keybindingManager.registerWithHighPrior({
       key: [{ keyCode: 'Backspace' }, { keyCode: 'Delete' }],
@@ -69,6 +87,7 @@ export class PathEditor {
     for (const token of this.eventTokens) {
       this.editor.keybindingManager.unregister(token);
     }
+    this.eventTokens = [];
   }
 
   /**