Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid the right-click menu goes off the screen #190

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

honorsin
Copy link
Contributor

@honorsin honorsin commented Sep 28, 2024

see issue: #186

@F-star
Copy link
Owner

F-star commented Sep 29, 2024

Good job!

There are some optimition tips, can you resovle them by the way?

  1. move contextmenu to red box position.

image

  1. set padding if has space. Maybe 100px is good (similar to Figma)

image

@honorsin
Copy link
Contributor Author

honorsin commented Sep 29, 2024

Good job!

There are some optimition tips, can you resovle them by the way?

  1. move contextmenu to red box position.

image

  1. set padding if has space. Maybe 100px is good (similar to Figma)

image

sure, I will handle these
and I checked figma to set space padding just 50px, if it's not okay, feel free to change it

@honorsin honorsin force-pushed the fix/contextmenu branch 4 times, most recently from eccb007 to e4d4e65 Compare September 29, 2024 11:02
@F-star F-star merged commit 811a3ba into F-star:main Sep 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants