feat(account-linking): better error handling#562
Merged
Brutus5000 merged 3 commits intoFAForever:developfrom Jan 23, 2025
Ivan-Shaml:feat/account-linking-better-error-handling
Merged
feat(account-linking): better error handling#562Brutus5000 merged 3 commits intoFAForever:developfrom Ivan-Shaml:feat/account-linking-better-error-handling
Brutus5000 merged 3 commits intoFAForever:developfrom
Ivan-Shaml:feat/account-linking-better-error-handling
Conversation
Brutus5000
previously approved these changes
Jan 23, 2025
Member
Brutus5000
left a comment
Brutus5000
left a comment
There was a problem hiding this comment.
Looks good, I am to lazy to test this locally.
* better error handling for Steam and GOG account linking. If error occurs during account linking, now the flash message is being scrolled to in the view port, and it gets highlighted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better error handling for Steam and GOG account linking. If error occurs during account linking, now the flash message is being scrolled to, in the viewport, and it gets highlighted
Closes #549