Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 ref_mask_res-2 and T1w_template_res-2 fields are moved out of regis… #2178

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

birajstha
Copy link
Contributor

Fixes

Fixes #2176 by @sgiavasis

Description

The ref_mask_res-2 and T1w_template_res-2 fields are moved out of registration and into surface under abcd_prefreesurfer_prep.

Technical details

Tests

Tested with #p023 of the many_pipelines project and it completes test-config run without error

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@birajstha birajstha requested a review from shnizzedy January 28, 2025 18:37
@birajstha birajstha self-assigned this Jan 28, 2025
@birajstha birajstha linked an issue Jan 28, 2025 that may be closed by this pull request
1 task
@birajstha
Copy link
Contributor Author

Wow ! how I forget pre-commit always ?

Copy link
Member

@shnizzedy shnizzedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!


Wow ! how I forget pre-commit always ?

#2178 (comment)

If you set up local pre-commit hooks it'll run automatically each time you commit locally

@birajstha birajstha requested a review from sgiavasis January 29, 2025 19:59
@birajstha birajstha merged commit 3ffec09 into develop Feb 5, 2025
24 checks passed
@birajstha birajstha deleted the abcd-prep branch February 6, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🔧 Move abcd-prep surface options in config
2 participants