Open
Conversation
suvarchal
reviewed
Jul 1, 2025
| !here update only those initialized in the init_tracers. (values, valuesAB, edge_up_dn_grad, ...) | ||
| !$ACC UPDATE DEVICE(tracers%data(tr_num)%values, tracers%data(tr_num)%valuesAB) & | ||
| !$ACC DEVICE(tracers%work%edge_up_dn_grad) !!& | ||
| !!$ACC UPDATE DEVICE(tracers%data(tr_num)%values, tracers%data(tr_num)%valuesAB, tracers%data(tr_num)%valuesold) |
Collaborator
There was a problem hiding this comment.
is this 227 meant to be comment?
Collaborator
Author
There was a problem hiding this comment.
I opened this while phase1 benchmarks are running. I branched it out from Phase1. That's why it's commented out. But after my first commit, we can start the conversation. Please ignore this PR for now.
suvarchal
reviewed
Jul 1, 2025
Collaborator
Author
|
Can I select "Resolve" for your reviews @suvarchal ? |
Collaborator
Author
Benchmarks for Phase 1 & Phase 2
Due to the usage of many if loops in the cpu code, there is a massive reduction in the warp occupancy rate, which shot up the computation time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diff_tracers_alesubroutine run completely on the GPUdiff_tracers_alediff_part_hor_redidiff_ver_part_expl_alediff_ver_part_redi_expldiff_ver_part_impl_alediff_part_bh(These are not touched as they are part of
recom)diff_ver_recom_explget_seawater_viscocityget_particle_densityballastver_sinking_recomver_sinking_recom_benthos