Draft
Conversation
This commit includes bugfixes, new diagnostics variables for grazing and code pieces to track BGC tracer budget.
Add recom initialzation and sbc files for recom. Standard setup for recom is enable_3zoo2det = .true. and enable_coccos = .false. (namelist.recom)
Build REcoM CI test. Add push trigger and improve debugging.
- namelist.recom and namelist.tra required by REcoM (not auto-generated) - Updated file paths to use local copies in work directory - Set REcoM_restart=false for initialization from climatology - Workflow copies these template files to work_recom/
Added mslp (mean sea level pressure) forcing configuration to enable CO2 flux calculations in REcoM. Without atmospheric pressure, the CO2 flux calculation fails with NaN values. Changes: - Added namelist.forcing section with l_mslp=True - Configured to read from 'slp.' files with 'slp' variable - Copy PHC2_salx.nc and runoff.nc to work directory in CI
…orcing The default namelist.forcing.CORE2 already has mslp (atmospheric pressure) configured but disabled (l_mslp=.false.). Patch it to l_mslp=.true. in the workflow to enable reading of slp.*.nc files. This is needed for REcoM CO2 flux calculations which require atmospheric pressure (Patm). Removed unnecessary namelist.forcing section from setup.yml since we just patch the default config file directly.
Namelist for REcoM3.1 are updated (for albedo)
Grazing diagnostics results in segmentation faulf in 2p1z1d setup. Macrozooplankton allocation and initialization is revisited. Deallocation was not an issue.
ESM tools cause problems in coupled model run If double precision sign is in the namelist.recom. d0 is removed.
Tracer fields have different numbers depending on configuration. Output routine is now aware of which configuration we use. 1. **Tracer ID 1001-1022 Base tracers** always present in all configuration: 1. **Tracer ID 1023-1028 have different meanings** depending on configuration: - In **COCCOS-ONLY**: 1023-1025 are Coccos (N,C,Chl), 1026-1028 are Phaeo (N,C,Chl) - In **3ZOO2DET configs**: 1023-1024 are Zoo2 (N,C), 1025-1028 are Det2 pool - In **BASE with rivers**: 1023 is DOCt 2. **Tracer ID 1029-1031** vary by configuration: - In **FULL model**: Coccos (N,C,Chl) - In **3ZOO2DET-ONLY**: 1029-1030 are Microzoo (N,C) - In **COCCOS-ONLY with rivers**: 1029 is DOCt 3. **Tracer ID 1032-1036** only exist in **FULL model**: - 1032-1034: Phaeocystis (N,C,Chl) - 1035-1036: Microzooplankton (N,C) 4. **Tracer ID 1037** only in **FULL model with rivers**: DOCt 5. **Added comprehensive comments** explaining which configuration uses which tracer IDs to prevent confusion.
Terrestrial DOC input is added as a new tracer. Input variables are read from a Netcdf file using a new subroutine as standard FESOM routines do not help in this case.
Update namelist.config file for various recom setups.
REcoM runs with more than 35 tracer fields. Therefore, we increase maximum number of allowed restart files.
DIC budget calculations are updated. We have now the correct split. Budget closes. It is extended to the variables of DIN, All and DSi. Photosynthesis, respiration, N assimilation and remineralization diagnostics are added.
…ication and permanent burial of organic matter in marine sediments. Update recom output variables. - Denitrification: Uses Middelburg et al. (1996) parameterization to calculate nitrogen removal as a function of organic carbon flux - Permanent Burial: Uses Dunne et al. (2007) formulation to calculate burial efficiency and permanent removal of C, N, Si, and CaCO3 - Calcite Dissolution: Accounts for calcite preservation based on carbonate saturation state (Omega_calcite) - Update output streams for the REcoM tracer variables (mocsy 3D outputs, missing ballasting outputs and burial)
We hhave either 2p or 4p cases. 3p setup is not needed anymore.
Collaborator
Author
|
I am not allowed to add the following yml file. .github/workflows/fesom2_recom.yml name: "FESOM2: REcoM Biogeochemistry" Controls when the action will run. Triggers the workflow on pull request only.on: A workflow run is made up of one or more jobs that can run sequentially or in paralleljobs: |
Collaborator
|
Hey @ogurses, & @patrickscholz. I suggest we first merge #863, then #802. Then we update this branch and merge here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update REcoM in FESOM2.7