Conversation
Contributor
|
in moment the CI test are failing, i guess this needs more encapsulation so it doesnt mess with our default cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am including here the two subroutines I setup with the help of Dima and Patrick to add freshwater anomaly around the coasts of Antarctica (with different masks options), at the surface or at specific depths.
I also included a passive tracer where the freshwater anomaly is imposed (tra_304) and it is possible to modify the temperature field to take into account the latent heat of fusion corresponding to the freshwater flux.
In this case I use "linfs" as vertical coordinate so for the surface I modify the virtual salinity flux instead of imposing an actual freshwater volume.
One thing that would make it easier to use would be for sure to add two flags in the config files to call the experiments without having to do it manually and then recompile (but taking into account that part of it is only for linfs), I didn't do it because I had to modify manually the flux amount that was time-dependent so in the end I left it like this.
I hope this is a good start at least for now.