Skip to content

fix: set YAC field timestep properly #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nils3er wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Draft

fix: set YAC field timestep properly #869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/cpl_yac_driver.F90
View file
Open in desktop
Copy link
Collaborator

@sveta-loza sveta-loza Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes introduced correct missing initialization of information about time stepping when setting coupling via YAC. Works fine for different time step related settings.

Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ subroutine cpl_yac_define_unstr(partit, mesh)
integer :: ierr, i, j, k, nbr_vertices, nbr_boundary_nodes, nbr_connections, vtx_idx, c2v_idx
integer :: curr_elem, curr_edge
logical, allocatable :: node_is_boundary(:)
character(len=4) :: dt_str
character(len=8) :: dt_str
character(LEN=24) :: startdatetime

#include "associate_part_def.h"
Expand All @@ -112,6 +112,8 @@ subroutine cpl_yac_define_unstr(partit, mesh)
INT(timenew)/3600, MODULO(INT(timenew), 3600)/60, MODULO(INT(timenew), 60), &
INT(MODULO(timenew, 1.0_WP)*1000)

WRITE(dt_str, '(I8.8)') INT(dt*1000)

CALL yac_fdef_datetime(startdatetime)

! find boundary nodes
Expand Down Expand Up @@ -248,7 +250,7 @@ subroutine cpl_yac_define_unstr(partit, mesh)
DO i=1,nsend
CALL yac_fdef_field(cpl_send(i), comp_id, [points_id], 1, &
cpl_send_collection_size(i), &
dt_str, YAC_TIME_UNIT_SECOND, send_field_id(i))
dt_str, YAC_TIME_UNIT_MILLISECOND, send_field_id(i))
END DO

cpl_recv(1) = 'taux'
Expand All @@ -268,7 +270,7 @@ subroutine cpl_yac_define_unstr(partit, mesh)

DO i=1,nrecv
CALL yac_fdef_field(cpl_recv(i), comp_id, [points_id], 1, cpl_recv_collection_size(i), &
dt_str, YAC_TIME_UNIT_SECOND, recv_field_id(i))
dt_str, YAC_TIME_UNIT_MILLISECOND, recv_field_id(i))
END DO

CALL yac_fenddef(ierr)
Expand Down
Loading